commit b2a90b6ba618a3dd53aca11322afc1c045302105
author Chih-Hung Hsieh <chh@google.com> Tue Dec 05 10:27:39 2017 -0800
committer Chih-Hung Hsieh <chh@google.com> Tue Dec 05 10:27:39 2017 -0800
tree da764ccddc997cf81bb7a88089563f0f29cd695a
parent 5281f56377bebf9932b14cd7f6490117612acfc0

Use -Werror in frameworks/native/cmds/cmd

* Ignore return value of getfilecon?

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: Ic7d67907a1cf0ba415aa0753bbd55bde06c8dd06
Merged-In: I341e6047dbb5b49a92f69df74b073d2f54a7754d

cmds/cmd/Android.mk

diff --git a/cmds/cmd/Android.mk b/cmds/cmd/Android.mk
index d565e57..4868555 100644
--- a/cmds/cmd/Android.mk
+++ b/cmds/cmd/Android.mk
@@ -10,6 +10,8 @@
     libselinux \
 	libbinder
 
+LOCAL_CFLAGS := -Wall -Werror
+
 LOCAL_C_INCLUDES += \
     $(JNI_H_INCLUDE)
 

cmds/cmd/cmd.cpp

diff --git a/cmds/cmd/cmd.cpp b/cmds/cmd/cmd.cpp
index 014c995..022d3dd 100644
--- a/cmds/cmd/cmd.cpp
+++ b/cmds/cmd/cmd.cpp
@@ -78,7 +78,7 @@
         if (is_selinux_enabled() && seLinuxContext.size() > 0) {
             String8 seLinuxContext8(seLinuxContext);
             security_context_t tmp = NULL;
-            int ret = getfilecon(fullPath.string(), &tmp);
+            getfilecon(fullPath.string(), &tmp);
             Unique_SecurityContext context(tmp);
             int accessGranted = selinux_check_access(seLinuxContext8.string(), context.get(),
                     "file", "write", NULL);