commit ae9deebc5282130e7cd84f146b97fdbd9fb71b88
author Frederick Mayle <fmayle@google.com> Thu Jun 23 23:42:08 2022 +0000
committer Frederick Mayle <fmayle@google.com> Mon Jun 27 18:56:01 2022 +0000
tree 0e8c03383aa79d8b1b164273ea3104612506e2e2
parent 332a29a57f332773e6eb44e404f0c55d1888f2eb

libbinder: Add test for null non-nullable binder return

Test: atest binderRpcTest
Change-Id: If10aac2b040f5de53516528821c6623c4b528cb8

libs/binder/tests/binderRpcTest.cpp

diff --git a/libs/binder/tests/binderRpcTest.cpp b/libs/binder/tests/binderRpcTest.cpp
index 5161469..141fa38 100644
--- a/libs/binder/tests/binderRpcTest.cpp
+++ b/libs/binder/tests/binderRpcTest.cpp
@@ -202,6 +202,10 @@
         }
         return Status::ok();
     }
+    Status getNullBinder(sp<IBinder>* out) override {
+        out->clear();
+        return Status::ok();
+    }
     Status pingMe(const sp<IBinder>& binder, int32_t* out) override {
         if (binder == nullptr) {
             std::cout << "Received null binder!" << std::endl;
@@ -802,6 +806,13 @@
     EXPECT_EQ(single + single, doubled);
 }
 
+TEST_P(BinderRpc, InvalidNullBinderReturn) {
+    auto proc = createRpcTestSocketServerProcess({});
+
+    sp<IBinder> outBinder;
+    EXPECT_EQ(proc.rootIface->getNullBinder(&outBinder).transactionError(), UNEXPECTED_NULL);
+}
+
 TEST_P(BinderRpc, CallMeBack) {
     auto proc = createRpcTestSocketServerProcess({});