commit ad34a68198c65bea568bac779fd8ad2937ba8087
author Garfield Tan <xutan@google.com> Tue May 21 15:25:35 2024 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Tue May 21 15:25:35 2024 +0000
tree e1fc6f5ebb60726fb16b82fd3cbf6a8c817e7680
parent 8eb8f35c8d45282e480426bc26543acf31230cb8

Revert "SF: Update metadata of unvisible layers to backend"

This reverts commit 8eb8f35c8d45282e480426bc26543acf31230cb8.

Reason for revert: b/341389467#comment3

Change-Id: I318d6b3d324be0bfa400e2759b22f1bdbc91e9ed

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index f0c7ff0..33dbab0 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -9233,9 +9233,7 @@
     std::vector<std::pair<Layer*, LayerFE*>> layers;
     if (mLayerLifecycleManagerEnabled) {
         nsecs_t currentTime = systemTime();
-        const bool needsMetadata = mCompositionEngine->getFeatureFlags().test(
-                compositionengine::Feature::kSnapshotLayerMetadata);
-        mLayerSnapshotBuilder.forEachSnapshot(
+        mLayerSnapshotBuilder.forEachVisibleSnapshot(
                 [&](std::unique_ptr<frontend::LayerSnapshot>& snapshot) FTL_FAKE_GUARD(
                         kMainThreadContext) {
                     if (cursorOnly &&
@@ -9258,12 +9256,6 @@
                     layerFE->mSnapshot = std::move(snapshot);
                     refreshArgs.layers.push_back(layerFE);
                     layers.emplace_back(legacyLayer.get(), layerFE.get());
-                },
-                [needsMetadata](const frontend::LayerSnapshot& snapshot) {
-                    return snapshot.isVisible ||
-                            (needsMetadata &&
-                             snapshot.changes.test(
-                                     frontend::RequestedLayerState::Changes::Metadata));
                 });
     }
     if (!mLayerLifecycleManagerEnabled) {