commit a416e7b190b0275234221e8074ca30c914ce0533
author Steven Moreland <smoreland@google.com> Tue May 11 16:22:55 2021 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue May 11 16:22:55 2021 +0000
tree 37238286eb20409f9d537aac666025a1b121b75c
parent 94a9ae334ed3c4690a3fc9d3d1ea7180784bcdf3
parent 8193c1884c68c6355d662a4e9f8af679174b9b3b

Merge "libbinder: RPC - add DOS TODO"

libs/binder/RpcServer.cpp

diff --git a/libs/binder/RpcServer.cpp b/libs/binder/RpcServer.cpp
index a6850ff..51c770e 100644
--- a/libs/binder/RpcServer.cpp
+++ b/libs/binder/RpcServer.cpp
@@ -134,7 +134,8 @@
         }
         LOG_RPC_DETAIL("accept4 on fd %d yields fd %d", mServer.get(), clientFd.get());
 
-        // TODO(b/183988761): cannot trust this simple ID
+        // TODO(b/183988761): cannot trust this simple ID, should not block this
+        // thread
         LOG_ALWAYS_FATAL_IF(!mAgreedExperimental, "no!");
         int32_t id;
         if (sizeof(id) != read(clientFd.get(), &id, sizeof(id))) {