commit 9f14ce60756dbbae9cecf03351a007c28c83ba8e
author Steven Moreland <smoreland@google.com> Thu Aug 08 16:06:19 2019 -0700
committer Steven Moreland <smoreland@google.com> Thu Aug 08 16:06:19 2019 -0700
tree 657a8f55a95deab94a08b68f464c7a34c6213185
parent a9860b6d18de4a6bf2b5c4cea92b0cc71ca2e5be

libbinder: mark transact as final

Subclasses of BpBinder/BBinder should override onTransact, not transact.

Bug: 136027762
Test: TH
Change-Id: I1d48ac8c4b5cb147e1d378e6ce1238338d93d3e7

libs/binder/include/binder/Binder.h

diff --git a/libs/binder/include/binder/Binder.h b/libs/binder/include/binder/Binder.h
index 1537e69..dec75f5 100644
--- a/libs/binder/include/binder/Binder.h
+++ b/libs/binder/include/binder/Binder.h
@@ -38,7 +38,7 @@
     virtual status_t    transact(   uint32_t code,
                                     const Parcel& data,
                                     Parcel* reply,
-                                    uint32_t flags = 0);
+                                    uint32_t flags = 0) final;
 
     // NOLINTNEXTLINE(google-default-arguments)
     virtual status_t    linkToDeath(const sp<DeathRecipient>& recipient,

libs/binder/include/binder/BpBinder.h

diff --git a/libs/binder/include/binder/BpBinder.h b/libs/binder/include/binder/BpBinder.h
index e71541b..28599f4 100644
--- a/libs/binder/include/binder/BpBinder.h
+++ b/libs/binder/include/binder/BpBinder.h
@@ -45,7 +45,7 @@
     virtual status_t    transact(   uint32_t code,
                                     const Parcel& data,
                                     Parcel* reply,
-                                    uint32_t flags = 0);
+                                    uint32_t flags = 0) final;
 
     // NOLINTNEXTLINE(google-default-arguments)
     virtual status_t    linkToDeath(const sp<DeathRecipient>& recipient,