commit 99157624317005011ae57e15a6482c35cea085e5
author Steven Moreland <smoreland@google.com> Mon Sep 13 16:27:34 2021 -0700
committer Steven Moreland <smoreland@google.com> Mon Sep 13 16:41:28 2021 -0700
tree 4219b6435370e4cd20ff69914bf5105baeb6a0a4
parent 728587b2851fa5aab102a16d55048a8deb23f18e

libbinder: hide BpBinder::create(*) functions

There is no need to have these around, and having them exposed
potentially means they could be stuck in the ABI.

They are created (instead of absorbed into the private constructors)
because of the additional UID tracking logic there.

Bug: 167966510
Test: binderRpcTest
Change-Id: I673d7a4c591a1b004f3214e8a17b48e54e91171d

libs/binder/ProcessState.cpp

diff --git a/libs/binder/ProcessState.cpp b/libs/binder/ProcessState.cpp
index 15b8604..4fe4fe6 100644
--- a/libs/binder/ProcessState.cpp
+++ b/libs/binder/ProcessState.cpp
@@ -212,7 +212,7 @@
     binder_node_info_for_ref info;
     memset(&info, 0, sizeof(binder_node_info_for_ref));
 
-    info.handle = binder->getPrivateAccessorForId().binderHandle();
+    info.handle = binder->getPrivateAccessor().binderHandle();
 
     status_t result = ioctl(mDriverFD, BINDER_GET_NODE_INFO_FOR_REF, &info);
 
@@ -301,7 +301,7 @@
                    return nullptr;
             }
 
-            sp<BpBinder> b = BpBinder::create(handle);
+            sp<BpBinder> b = BpBinder::PrivateAccessor::create(handle);
             e->binder = b.get();
             if (b) e->refs = b->getWeakRefs();
             result = b;