commit 98ca4a2bacc1479c61fe15c463bd195330082a5b
author Prabir Pradhan <prabirmsp@google.com> Tue Jan 09 23:51:50 2024 +0000
committer Prabir Pradhan <prabirmsp@google.com> Tue Jan 09 23:54:02 2024 +0000
tree 1150232e8445fc1b7e522dde4b93a25bccdf8466
parent b13da8fa00af57b14318fb5b0ce64d6c700852ad

InputDispatcher: Check for normal connection for consistency

Whenever we test a connection status, check against Status::NORMAL
everywhere in dispatcher, for consistency.

Bug: 319186639
Test: atest inputflinger_tests
Change-Id: I01c1eb48d94b5a4d164080ffc185928445084c66

services/inputflinger/dispatcher/InputDispatcher.cpp

diff --git a/services/inputflinger/dispatcher/InputDispatcher.cpp b/services/inputflinger/dispatcher/InputDispatcher.cpp
index 6319322..2fbbc20 100644
--- a/services/inputflinger/dispatcher/InputDispatcher.cpp
+++ b/services/inputflinger/dispatcher/InputDispatcher.cpp
@@ -3840,8 +3840,7 @@
               connection->getInputChannelName().c_str(), seq, toString(handled));
     }
 
-    if (connection->status == Connection::Status::BROKEN ||
-        connection->status == Connection::Status::ZOMBIE) {
+    if (connection->status != Connection::Status::NORMAL) {
         return;
     }
 
@@ -4114,7 +4113,7 @@
 void InputDispatcher::synthesizePointerDownEventsForConnectionLocked(
         const nsecs_t downTime, const std::shared_ptr<Connection>& connection,
         ftl::Flags<InputTarget::Flags> targetFlags) {
-    if (connection->status == Connection::Status::BROKEN) {
+    if (connection->status != Connection::Status::NORMAL) {
         return;
     }