SurfaceFlinger: call setFrameTimelineVsyncForTransaction with valid id
Remove unnecessary calls to setFrameTimelineVsyncForTransaction when
the vsync id is not valid.
Test: atest SurfaceFlinger_tests
Bug: 171252403
Change-Id: I6233baf5f623c1bc0f3856abb360982c566328ab
diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 1119fce..57c4d52 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -3787,9 +3787,7 @@
}
if (what & layer_state_t::eFrameTimelineVsyncChanged) {
layer->setFrameTimelineVsyncForTransaction(s.frameTimelineVsyncId, postTime);
- } else {
- // TODO (b/171252403) We are calling this too much, potentially triggering
- // unnecessary work
+ } else if (frameTimelineVsyncId != ISurfaceComposer::INVALID_VSYNC_ID) {
layer->setFrameTimelineVsyncForTransaction(frameTimelineVsyncId, postTime);
}
if (what & layer_state_t::eFixedTransformHintChanged) {