commit 95f686177953b5558b3154269b6407b7325604dc
author Arthur Hung <arthurhung@google.com> Thu Apr 07 14:08:22 2022 +0800
committer Arthur Hung <arthurhung@google.com> Tue Apr 26 01:46:35 2022 +0000
tree 8057a69212761b202976129bf4fa964739bd43ca
parent f18ac6cac6c38bfaf02068fe167d3936c70469bf

Set initial meta state to AMETA_NONE

Currently, the default meta state is AMETA_NUM_LOCK_ON, that may cause
some keyboard such as Apple Wireless Keyboard send the mismatched keys.

Ideally, if the keyboard didn't contain the led key, it should not
handle such key to change any state, this CL temporarily set the
initialied state to none to prevent some unexpected behavior when
user connected a new keyboard.

Bug: 194465459
Test: atest inputflinger_tests
Change-Id: Iad9fc01d16444e7d40a704678d3d27cdd110765c

services/inputflinger/reader/InputReader.cpp

diff --git a/services/inputflinger/reader/InputReader.cpp b/services/inputflinger/reader/InputReader.cpp
index 31d331b..9c5a129 100644
--- a/services/inputflinger/reader/InputReader.cpp
+++ b/services/inputflinger/reader/InputReader.cpp
@@ -47,8 +47,8 @@
         mEventHub(eventHub),
         mPolicy(policy),
         mQueuedListener(listener),
-        mGlobalMetaState(0),
-        mLedMetaState(AMETA_NUM_LOCK_ON),
+        mGlobalMetaState(AMETA_NONE),
+        mLedMetaState(AMETA_NONE),
         mGeneration(1),
         mNextInputDeviceId(END_RESERVED_ID),
         mDisableVirtualKeysTimeout(LLONG_MIN),