commit 94ff79988ce790941214b15e8160f949cb470868
author Rachel Lee <rnlee@google.com> Thu Aug 31 15:15:22 2023 -0700
committer Rachel Lee <rnlee@google.com> Thu Aug 31 16:30:56 2023 -0700
tree b4ee9757b6807353122ea6cbb7b15250e9a4efb2
parent 8bba9eeeb81a2af97252658ba56dfd53833087b8

Fix atrace for summarize w/ category.

Want to correctly show the frame rate category in the trace when there
is a category chosen.

Bug: 284911776
Test: perfetto
Change-Id: If9c7bbc9223e07de9ba24a739b326ae5239f3d2f

services/surfaceflinger/Scheduler/LayerHistory.cpp

diff --git a/services/surfaceflinger/Scheduler/LayerHistory.cpp b/services/surfaceflinger/Scheduler/LayerHistory.cpp
index c92e670..23eb31f 100644
--- a/services/surfaceflinger/Scheduler/LayerHistory.cpp
+++ b/services/surfaceflinger/Scheduler/LayerHistory.cpp
@@ -188,8 +188,8 @@
             const float layerArea = transformed.getWidth() * transformed.getHeight();
             float weight = mDisplayArea ? layerArea / mDisplayArea : 0.0f;
             const std::string categoryString = vote.category == FrameRateCategory::Default
-                    ? base::StringPrintf("category=%s", ftl::enum_string(vote.category).c_str())
-                    : "";
+                    ? ""
+                    : base::StringPrintf("category=%s", ftl::enum_string(vote.category).c_str());
             ATRACE_FORMAT_INSTANT("%s %s %s (%d%)", ftl::enum_string(vote.type).c_str(),
                                   to_string(vote.fps).c_str(), categoryString.c_str(),
                                   weight * 100);