commit 935590e6f9b71fdccbd597fb4cd12fc3911ea5b6
author Vishnu Nair <vishnun@google.com> Wed Feb 10 13:05:52 2021 -0800
committer Vishnu Nair <vishnun@google.com> Thu Feb 11 01:33:58 2021 +0000
tree 87511eec46fa2842de6ebb2f29813c220965d99d
parent a9b9fe40c28882f3db0b13dc9ac9b00b0fd2eab1

Fix acquire and framenumber mismatch in transaction complete callback

Test: manual test with frame metrics cls
Test: frametimeline tests to follow
Change-Id: Idb51ce8f3f5d58391ab864f41d1b01031e2b0aac

services/surfaceflinger/BufferStateLayer.cpp

diff --git a/services/surfaceflinger/BufferStateLayer.cpp b/services/surfaceflinger/BufferStateLayer.cpp
index cf87f62..763b453 100644
--- a/services/surfaceflinger/BufferStateLayer.cpp
+++ b/services/surfaceflinger/BufferStateLayer.cpp
@@ -452,6 +452,7 @@
         if (willPresent) {
             // If this transaction set an acquire fence on this layer, set its acquire time
             handle->acquireTime = mCallbackHandleAcquireTime;
+            handle->frameNumber = mCurrentState.frameNumber;
 
             // Notify the transaction completed thread that there is a pending latched callback
             // handle
@@ -623,8 +624,9 @@
     }
 
     for (auto& handle : mDrawingState.callbackHandles) {
-        handle->latchTime = latchTime;
-        handle->frameNumber = mDrawingState.frameNumber;
+        if (handle->frameNumber == mDrawingState.frameNumber) {
+            handle->latchTime = latchTime;
+        }
     }
 
     const int32_t layerId = getSequence();