commit 932fb4f2ace879efd2ed90d0120186f000acd612
author Tianyu Jiang <tianyuj@google.com> Thu Nov 15 11:09:58 2018 -0800
committer Tianyu Jiang <tianyuj@google.com> Fri Nov 30 18:21:07 2018 +0000
tree 6511ff49d4e7f9c8f175bec9be566f3c3e7b8143
parent df306c8acba817d52dfd7679ac69f7a2f40047c7

Change return values of type status_t from NO_ERROR to OK

in bufferhub related directories

Bug: 118696702
Fixes: 118696702
Test: all tests pass.
AHardwareBufferTest BufferHubBuffer_test BufferHubMetadata_test
buffer_hub_binder_service-test buffer_hub_queue_producer-test
libgui_test libsensor_test vrflinger_test buffer_hub-test
buffer_hub_queue-test dvr_buffer_queue-test dvr_api-test
dvr_display-test

Change-Id: Iee198ddbec035856185fcab34b0d631bd3726b77

services/vr/bufferhubd/IBufferHub.cpp

diff --git a/services/vr/bufferhubd/IBufferHub.cpp b/services/vr/bufferhubd/IBufferHub.cpp
index 022a9cc..5980873 100644
--- a/services/vr/bufferhubd/IBufferHub.cpp
+++ b/services/vr/bufferhubd/IBufferHub.cpp
@@ -30,7 +30,7 @@
                                             uint32_t format, uint64_t usage,
                                             uint64_t user_metadata_size) {
   Parcel data, reply;
-  status_t ret = NO_ERROR;
+  status_t ret = OK;
   ret |= data.writeInterfaceToken(IBufferHub::getInterfaceDescriptor());
   ret |= data.writeUint32(width);
   ret |= data.writeUint32(height);
@@ -39,13 +39,13 @@
   ret |= data.writeUint64(usage);
   ret |= data.writeUint64(user_metadata_size);
 
-  if (ret != NO_ERROR) {
+  if (ret != OK) {
     ALOGE("BpBufferHub::createBuffer: failed to write into parcel");
     return nullptr;
   }
 
   ret = remote()->transact(CREATE_BUFFER, data, &reply);
-  if (ret == NO_ERROR) {
+  if (ret == OK) {
     return interface_cast<IBufferClient>(reply.readStrongBinder());
   } else {
     ALOGE("BpBufferHub::createBuffer: failed to transact; errno=%d", ret);
@@ -56,18 +56,18 @@
 status_t BpBufferHub::importBuffer(uint64_t token,
                                    sp<IBufferClient>* outClient) {
   Parcel data, reply;
-  status_t ret = NO_ERROR;
+  status_t ret = OK;
   ret |= data.writeInterfaceToken(IBufferHub::getInterfaceDescriptor());
   ret |= data.writeUint64(token);
-  if (ret != NO_ERROR) {
+  if (ret != OK) {
     ALOGE("BpBufferHub::importBuffer: failed to write into parcel");
     return ret;
   }
 
   ret = remote()->transact(IMPORT_BUFFER, data, &reply);
-  if (ret == NO_ERROR) {
+  if (ret == OK) {
     *outClient = interface_cast<IBufferClient>(reply.readStrongBinder());
-    return NO_ERROR;
+    return OK;
   } else {
     ALOGE("BpBufferHub::importBuffer: failed to transact; errno=%d", ret);
     return ret;
@@ -94,7 +94,7 @@
       uint64_t token = data.readUint64();
       sp<IBufferClient> client;
       status_t ret = importBuffer(token, &client);
-      if (ret == NO_ERROR) {
+      if (ret == OK) {
         return reply->writeStrongBinder(IInterface::asBinder(client));
       } else {
         return ret;