commit 9210f10dd023b93c3e506b3073ebff72d1419388
author Patrick Williams <pdwilliams@google.com> Mon Nov 04 14:49:19 2024 -0600
committer Patrick Williams <pdwilliams@google.com> Mon Nov 04 14:49:19 2024 -0600
tree daae1891cdd4502173dd36e83395f09acc1c9b2f
parent e17dfdd38a017ba985fa446b41f36f5f7b94b419

Avoid unnecessary WindowInfo copies

Bug: 352744079
Flag: EXEMPT refactor
Test: presubmits
Change-Id: Iad7cefdf8fb2c1bb75b2f8b4970e3de422529523

services/inputflinger/dispatcher/InputDispatcher.cpp

diff --git a/services/inputflinger/dispatcher/InputDispatcher.cpp b/services/inputflinger/dispatcher/InputDispatcher.cpp
index 4f9d9e4..755995c 100644
--- a/services/inputflinger/dispatcher/InputDispatcher.cpp
+++ b/services/inputflinger/dispatcher/InputDispatcher.cpp
@@ -836,13 +836,9 @@
 }
 
 Result<void> validateWindowInfosUpdate(const gui::WindowInfosUpdate& update) {
-    struct HashFunction {
-        size_t operator()(const WindowInfo& info) const { return info.id; }
-    };
-
-    std::unordered_set<WindowInfo, HashFunction> windowSet;
+    std::unordered_set<int32_t> windowIds;
     for (const WindowInfo& info : update.windowInfos) {
-        const auto [_, inserted] = windowSet.insert(info);
+        const auto [_, inserted] = windowIds.insert(info.id);
         if (!inserted) {
             return Error() << "Duplicate entry for " << info;
         }