commit 8c4356c0ac57003787c20c3e4afda9dbf4f8a324
author Dominik Laskowski <domlaskowski@google.com> Mon Mar 21 08:19:54 2022 -0700
committer Dominik Laskowski <domlaskowski@google.com> Thu Mar 31 09:51:15 2022 -0700
tree 7c003ac798ed418328405d7576128213e32950f8
parent 4d5052d7080749fe6e90a7643f95b69c5b79feed

SF: Clean up RefreshRateOverlay

Flatten buffer cache, remove unused members, and fix conversion
warnings.

Skip animation transactions unless spinner is enabled.

Bug: 185535769
Bug: 129481165
Test: Apply follow-up fix and toggle overlay.
Change-Id: I14688f7b5d882f595322dfadd5cabbd5a8564301

services/surfaceflinger/DisplayDevice.cpp

diff --git a/services/surfaceflinger/DisplayDevice.cpp b/services/surfaceflinger/DisplayDevice.cpp
index f5a4b3d..9116fd3 100644
--- a/services/surfaceflinger/DisplayDevice.cpp
+++ b/services/surfaceflinger/DisplayDevice.cpp
@@ -471,9 +471,8 @@
         return;
     }
 
-    const auto [lowFps, highFps] = mRefreshRateConfigs->getSupportedRefreshRateRange();
-    mRefreshRateOverlay = std::make_unique<RefreshRateOverlay>(*mFlinger, lowFps.getIntValue(),
-                                                               highFps.getIntValue(), showSpinnner);
+    const auto fpsRange = mRefreshRateConfigs->getSupportedRefreshRateRange();
+    mRefreshRateOverlay = std::make_unique<RefreshRateOverlay>(fpsRange, showSpinnner);
     mRefreshRateOverlay->setLayerStack(getLayerStack());
     mRefreshRateOverlay->setViewport(getSize());
     mRefreshRateOverlay->changeRefreshRate(getActiveMode()->getFps());