commit 8a9bb84af27ac456c27175f22683fc5b6b41c731
author Steven Moreland <smoreland@google.com> Thu Dec 05 01:02:53 2024 +0000
committer Steven Moreland <smoreland@google.com> Sat Dec 07 00:33:12 2024 +0000
tree 7d3fea02bceaa6c49a51ffde08414dfe6168d8b7
parent 90b14eab96ef0de6f91375a2d55768798ce11059

servicemanager: remove pre-4.4 pidcon path

setRequestingSid was added since kernel version 4.4, so
we should no longer need it.

Bug: 376122465
Test: boot
Change-Id: I1ebc04570aae6a441f3a37103b50815514aa6a57

cmds/servicemanager/Access.cpp

diff --git a/cmds/servicemanager/Access.cpp b/cmds/servicemanager/Access.cpp
index 8098724..6e2abf6 100644
--- a/cmds/servicemanager/Access.cpp
+++ b/cmds/servicemanager/Access.cpp
@@ -34,7 +34,9 @@
 
 #ifdef __ANDROID__
 static std::string getPidcon(pid_t pid) {
-    android_errorWriteLog(0x534e4554, "121035042");
+    CHECK_EQ(nullptr, IPCThreadState::self()->getServingStackPointer())
+            << "Did not get context from PID " << pid
+            << ". We should always get contexts from other processes.";
 
     char* lookup = nullptr;
     if (getpidcon(pid, &lookup) < 0) {