commit 8a662475ef1a4aedddc21180239cad86b1820230
author Yifan Hong <elsk@google.com> Thu Sep 24 11:50:50 2020 -0700
committer Yifan Hong <elsk@google.com> Thu Sep 24 14:31:22 2020 -0700
tree 8150fe40bec56edd68a8c9c17f6f326803cb873e
parent 52e3b47cae759317fb4a87df25568b897b132585

lshal: Add fqname to debug error messages

If any error comes up when invoking debug, write fqname and the error
message to the error output stream.

Test: manual. Add addPostCommandTask to a HAL that keeps writing to the
fd after debug() finishes. lshal debug terminates with fqname and
the error message `timeout reading from pipe, output may be truncated.`

Fixes: 169247570

Change-Id: Idf8944e3cde08dc86766b144c4a3037cbcf6b3dc

cmds/lshal/Lshal.cpp

diff --git a/cmds/lshal/Lshal.cpp b/cmds/lshal/Lshal.cpp
index 2c3efe5..99cb93a 100644
--- a/cmds/lshal/Lshal.cpp
+++ b/cmds/lshal/Lshal.cpp
@@ -141,7 +141,7 @@
         }
     }
 
-    PipeRelay relay(out);
+    PipeRelay relay(out, err, interfaceName, instanceName);
 
     if (relay.initCheck() != OK) {
         std::string msg = "PipeRelay::initCheck() FAILED w/ " + std::to_string(relay.initCheck());