commit 7f273710b11b784329ef0ef6f4b340705533447d
author Pawan Wagh <waghpawan@google.com> Wed Nov 30 15:56:10 2022 +0000
committer Pawan Wagh <waghpawan@google.com> Wed Dec 07 05:46:14 2022 +0000
tree f71cf299bbeba1a9ef795d2522982bebd9cbd014
parent c92d874738b1e150816dc712a6f6df11e31f53f7

limit extra fds in random parcel

Fuzzers are hitting open fd limit for large inputs.
Restricting number of fds which are added in extraFds.

Bug: 257828440
Bug: 260119717
Bug: 258307992
Bug: 260738157
Test: m libbinder_random_parcel
Change-Id: I401ebe1dd754f891cbddd0d982ab4439984c3e3f

libs/binder/tests/parcel_fuzzer/random_parcel.cpp

diff --git a/libs/binder/tests/parcel_fuzzer/random_parcel.cpp b/libs/binder/tests/parcel_fuzzer/random_parcel.cpp
index edc695f..f0beed2 100644
--- a/libs/binder/tests/parcel_fuzzer/random_parcel.cpp
+++ b/libs/binder/tests/parcel_fuzzer/random_parcel.cpp
@@ -73,6 +73,11 @@
                                                                                 1));
                         CHECK(OK == p->writeFileDescriptor(fd.get(), false /*takeOwnership*/));
                     } else {
+                        // b/260119717 - Adding more FDs can eventually lead to FD limit exhaustion
+                        if (options->extraFds.size() > 1000) {
+                            return;
+                        }
+
                         std::vector<base::unique_fd> fds = getRandomFds(&provider);
                         CHECK(OK ==
                               p->writeFileDescriptor(fds.begin()->release(),