commit 7cdf5c26a1c53eae846c87e10eb2d2f34a8a2f34
author Andrei Homescu <ahomescu@google.com> Sat Apr 30 03:41:16 2022 +0000
committer Andrei Homescu <ahomescu@google.com> Thu May 19 03:19:42 2022 +0000
tree a103d860f30885e607de0f854ca76b757f1391b2
parent 491e84517155733af8d5f1e7ddfd4bacbc78bf92

libbinder: fix one implicit cast that triggers sanitizer

One bitwise-complement of a constant value in BpBinder
triggers UBSan on Trusty. This fixes that by adding
an explicit static cast.

Bug: 224644083
Test: m
Change-Id: Idc771d8e922fbeaf8d3342dfb9b63a423df6a737

libs/binder/BpBinder.cpp

diff --git a/libs/binder/BpBinder.cpp b/libs/binder/BpBinder.cpp
index 921e57c..1eb2ffd 100644
--- a/libs/binder/BpBinder.cpp
+++ b/libs/binder/BpBinder.cpp
@@ -279,7 +279,7 @@
     if (mAlive) {
         bool privateVendor = flags & FLAG_PRIVATE_VENDOR;
         // don't send userspace flags to the kernel
-        flags = flags & ~FLAG_PRIVATE_VENDOR;
+        flags = flags & ~static_cast<uint32_t>(FLAG_PRIVATE_VENDOR);
 
         // user transactions require a given stability level
         if (code >= FIRST_CALL_TRANSACTION && code <= LAST_CALL_TRANSACTION) {