commit 7b9d189574fdf530df9c2e30e4fd799c9a25e6b4
author Siarhei Vishniakou <svv@google.com> Wed Jul 05 18:58:41 2017 -0700
committer Siarhei Vishniakou <svv@google.com> Fri Jul 07 11:59:36 2017 -0700
tree bd5e80eaed179aacd71e648a02ee6c1f9bbdd7fb
parent 20ce19cd28e0e21af2748b64a49f958e811ce5b2

Fix SIGABRT caused by integer sanitizer.

Test: m -j and use flings in settings menu.
Change-Id: I7c15c610ed2d74b128a2924c097fb7dc351ea5f4

libs/input/VelocityTracker.cpp

diff --git a/libs/input/VelocityTracker.cpp b/libs/input/VelocityTracker.cpp
index 7f6b157..75ad71c 100644
--- a/libs/input/VelocityTracker.cpp
+++ b/libs/input/VelocityTracker.cpp
@@ -23,8 +23,9 @@
 // Log debug messages about the progress of the algorithm itself.
 #define DEBUG_STRATEGY 0
 
-#include <math.h>
+#include <inttypes.h>
 #include <limits.h>
+#include <math.h>
 
 #include <cutils/properties.h>
 #include <input/VelocityTracker.h>
@@ -46,8 +47,7 @@
 
 static float vectorDot(const float* a, const float* b, uint32_t m) {
     float r = 0;
-    while (m) {
-        m--;
+    for (size_t i = 0; i < m; i++) {
         r += *(a++) * *(b++);
     }
     return r;
@@ -55,8 +55,7 @@
 
 static float vectorNorm(const float* a, uint32_t m) {
     float r = 0;
-    while (m) {
-        m--;
+    for (size_t i = 0; i < m; i++) {
         float t = *(a++);
         r += t * t;
     }
@@ -67,11 +66,11 @@
 static String8 vectorToString(const float* a, uint32_t m) {
     String8 str;
     str.append("[");
-    while (m--) {
-        str.appendFormat(" %f", *(a++));
-        if (m) {
+    for (size_t i = 0; i < m; i++) {
+        if (i) {
             str.append(",");
         }
+        str.appendFormat(" %f", *(a++));
     }
     str.append(" ]");
     return str;
@@ -244,7 +243,7 @@
     mStrategy->addMovement(eventTime, idBits, positions);
 
 #if DEBUG_VELOCITY
-    ALOGD("VelocityTracker: addMovement eventTime=%lld, idBits=0x%08x, activePointerId=%d",
+    ALOGD("VelocityTracker: addMovement eventTime=%" PRId64 ", idBits=0x%08x, activePointerId=%d",
             eventTime, idBits.value, mActivePointerId);
     for (BitSet32 iterBits(idBits); !iterBits.isEmpty(); ) {
         uint32_t id = iterBits.firstMarkedBit();