commit 76f00826a546d7cf3543c0bf760a4cd0910bc78c
author Abhishek Gadewar <abhishekgadewar@meta.com> Thu May 09 17:02:18 2024 -0700
committer Abhishek Gadewar <abhishekgadewar@meta.com> Fri May 24 18:37:38 2024 -0700
tree 8e9ea40f2b78093107e10c4927fb95a6e2d3c266
parent fe63f670069facb658cc3ed50c7974c2da1c505d

Don't log error on success

Summary: std::map::erase(Key&) returns 0 on failure (key did not exist), 1 on success (key existed and was deleted). Prior to this change, PersistableBundle would log an error anytime a key was successfully deleted.

Test: added PersistableBundle test

Change-Id: I9c2f6cabd30f784d5dbde5dee1f3d0eb2461bd06
Signed-off-by: Abhishek Gadewar <abhishekgadewar@meta.com>

libs/binder/tests/Android.bp

diff --git a/libs/binder/tests/Android.bp b/libs/binder/tests/Android.bp
index 6800a8d..213d764 100644
--- a/libs/binder/tests/Android.bp
+++ b/libs/binder/tests/Android.bp
@@ -57,6 +57,7 @@
         "binderStatusUnitTest.cpp",
         "binderMemoryHeapBaseUnitTest.cpp",
         "binderRecordedTransactionTest.cpp",
+        "binderPersistableBundleTest.cpp",
     ],
     shared_libs: [
         "libbinder",