commit 758eb56f6259f3263a36abdb0777f16447fb4815
author LiZhihong <lizh52@lenovo.corp-partner.google.com> Thu Nov 03 15:28:29 2022 +0800
committer Siarhei Vishniakou <svv@google.com> Mon Feb 06 18:21:29 2023 +0000
tree 4064e7c31a9b4b24c019642e49702ddad767a398
parent 8a878356682afb9801816785ab7ade6f68384108

Add send ACTION_BUTTON_PRESS and ACTION_BUTTON_RELEASE in touchpad L/R

Touchpad L/R only upload ACTION_DOWN and ACTION_UP,
but mouse L/R upload ACTION_DOWN、ACTION_BUTTON_PRESS、
ACTION_BUTTON_RELEASE and ACTION_UP, there are
different. It may cause the app to fail to handle
touchpad L/R press behavior.

Test: manual
Bug: 237355203
Signed-off-by: LiZhihong <lizh52@lenovo.corp-partner.google.com>
Change-Id: I0934ae237e89eb65f3e9a34b2c12e5467052d43c

services/inputflinger/tests/InputReader_test.cpp

diff --git a/services/inputflinger/tests/InputReader_test.cpp b/services/inputflinger/tests/InputReader_test.cpp
index 1b04375..fe7af80 100644
--- a/services/inputflinger/tests/InputReader_test.cpp
+++ b/services/inputflinger/tests/InputReader_test.cpp
@@ -10084,6 +10084,26 @@
     ASSERT_EQ(AMOTION_EVENT_ACTION_HOVER_MOVE, args.action);
     ASSERT_NO_FATAL_FAILURE(assertPointerCoords(args.pointerCoords[0], 100 * scale, 100 * scale, 0,
                                                 0, 0, 0, 0, 0, 0, 0));
+
+    // BUTTON DOWN
+    processKey(mapper, BTN_LEFT, 1);
+    processSync(mapper);
+
+    // touchinputmapper design sends a move before button press
+    ASSERT_NO_FATAL_FAILURE(mFakeListener->assertNotifyMotionWasCalled(&args));
+    ASSERT_EQ(AMOTION_EVENT_ACTION_DOWN, args.action);
+    ASSERT_NO_FATAL_FAILURE(mFakeListener->assertNotifyMotionWasCalled(&args));
+    ASSERT_EQ(AMOTION_EVENT_ACTION_BUTTON_PRESS, args.action);
+
+    // BUTTON UP
+    processKey(mapper, BTN_LEFT, 0);
+    processSync(mapper);
+
+    // touchinputmapper design sends a move after button release
+    ASSERT_NO_FATAL_FAILURE(mFakeListener->assertNotifyMotionWasCalled(&args));
+    ASSERT_EQ(AMOTION_EVENT_ACTION_BUTTON_RELEASE, args.action);
+    ASSERT_NO_FATAL_FAILURE(mFakeListener->assertNotifyMotionWasCalled(&args));
+    ASSERT_EQ(AMOTION_EVENT_ACTION_UP, args.action);
 }
 
 TEST_F(MultiTouchInputMapperTest, WhenCapturedAndNotCaptured_GetSources) {