commit 7320612aeb8674a63106299f2cba5d23df1ca03b
author Carmen Jackson <carmenjackson@google.com> Tue Apr 18 15:37:57 2017 -0700
committer Carmen Jackson <carmenjackson@google.com> Tue Apr 18 15:55:29 2017 -0700
tree 644db6fbda44dfe2d4f2fa5d515715842f434b59
parent de47fabe1a512e33ad3eee912b541b0809885705

atrace: Don't NPE if we can't access hal-related tracepoint files.

This currently NPEs when Traceur attempts to start a trace.
Based on b/34242478, this is currently expected and we should fail
gracefully instead.

Bug: 37281960

Test: Starting a trace using Traceur on a userdebug build succeeds.

Change-Id: I082d5750625dec0e1db4a1dd341dc332d8dd752f

cmds/atrace/atrace.cpp

diff --git a/cmds/atrace/atrace.cpp b/cmds/atrace/atrace.cpp
index 05e1615..6cfbed9 100644
--- a/cmds/atrace/atrace.cpp
+++ b/cmds/atrace/atrace.cpp
@@ -552,7 +552,13 @@
                 // ignore
                 continue;
             }
+
             sp<IBase> interface = interfaceRet;
+            if (interface == nullptr) {
+                // ignore
+                continue;
+            }
+
             auto notifyRet = interface->notifySyspropsChanged();
             if (!notifyRet.isOk()) {
                 // ignore