commit 71da15ec7bc78232e23661875ba8fb815345b16b
author John Reck <jreck@google.com> Tue Mar 30 14:58:08 2021 -0400
committer John Reck <jreck@google.com> Wed Mar 31 14:27:52 2021 -0400
tree 2b1ab1beb867e53f28598acf353be85fa4b79b2d
parent 8827090d3e52acc2e52e83160dbbda11bc3caf2f

Adjust SET_DISPLAY_BRIGHTNESS check

Fixes: 183985553
Test: make & flash
Change-Id: Id0c7d7161d8a583b84a85e619966babd21232686

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 544727f..5be5734 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -5192,17 +5192,15 @@
         // captureLayers and captureDisplay will handle the permission check in the function
         case CAPTURE_LAYERS:
         case CAPTURE_DISPLAY:
-        case SET_DISPLAY_BRIGHTNESS:
         case SET_FRAME_TIMELINE_INFO:
         case GET_GPU_CONTEXT_PRIORITY:
         case GET_EXTRA_BUFFER_COUNT: {
             // This is not sensitive information, so should not require permission control.
             return OK;
         }
+        case SET_DISPLAY_BRIGHTNESS:
         case ADD_HDR_LAYER_INFO_LISTENER:
         case REMOVE_HDR_LAYER_INFO_LISTENER: {
-            // TODO (b/183985553): Should getting & setting brightness be part of this...?
-            // codes that require permission check
             IPCThreadState* ipc = IPCThreadState::self();
             const int pid = ipc->getCallingPid();
             const int uid = ipc->getCallingUid();