commit 6a0dc96728e07362d3c19fed554669a43987790c
author Steven Moreland <smoreland@google.com> Mon Oct 25 15:35:43 2021 -0700
committer Steven Moreland <smoreland@google.com> Mon Oct 25 22:36:42 2021 +0000
tree f14ad9470983c9b3468d5a5aef34d0312fbb3a32
parent 828b2acbb50a34ce0f59b51e5d07256d1fe9201e

binderRpcTest: respect network byte order

This test was setting a bad example before.

Bug: 167966510
Test: binderRpcTest
Change-Id: Ic0d1c9c267a0c52e8846aafc12f880e998500e82

libs/binder/tests/binderRpcTest.cpp

diff --git a/libs/binder/tests/binderRpcTest.cpp b/libs/binder/tests/binderRpcTest.cpp
index 0cbb880..7bbe3d7 100644
--- a/libs/binder/tests/binderRpcTest.cpp
+++ b/libs/binder/tests/binderRpcTest.cpp
@@ -663,13 +663,15 @@
                                         break;
                                     case AF_INET:
                                         CHECK_EQ(len, sizeof(sockaddr_in));
-                                        service->port = reinterpret_cast<const sockaddr_in*>(addr)
-                                                                ->sin_port;
+                                        service->port =
+                                                ntohs(reinterpret_cast<const sockaddr_in*>(addr)
+                                                              ->sin_port);
                                         break;
                                     case AF_INET6:
                                         CHECK_EQ(len, sizeof(sockaddr_in));
-                                        service->port = reinterpret_cast<const sockaddr_in6*>(addr)
-                                                                ->sin6_port;
+                                        service->port =
+                                                ntohs(reinterpret_cast<const sockaddr_in6*>(addr)
+                                                              ->sin6_port);
                                         break;
                                     default:
                                         LOG_ALWAYS_FATAL("Unrecognized address family %d",