SF: Convert to Android.bp
Eliminate the makefiles and convert to using blueprint files for
SurfaceFlinger. Along the way, set up a few things (filegroups,
cc_defaults) to add a unit test build in a change to come.
One configuration feature was dropped, as I was unsure of how to
replicate it in the blueprint configuration:
TARGET_32_BIT_SURFACEFLINGER
Test: Builds, usable on Pixel XL
Test: "atest SurfaceFlinger_test" works (but has failing tests)
Bug: None
Change-Id: I2d574855e53932fbb021afc9d61c4a3bb317330c
diff --git a/services/surfaceflinger/tests/Android.bp b/services/surfaceflinger/tests/Android.bp
new file mode 100644
index 0000000..04c62b3
--- /dev/null
+++ b/services/surfaceflinger/tests/Android.bp
@@ -0,0 +1,49 @@
+// Copyright (C) 2018 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+cc_test {
+ name: "SurfaceFlinger_test",
+ defaults: ["surfaceflinger_defaults"],
+ tags: ["test"],
+ test_suites: ["device-tests"],
+ srcs: [
+ "Stress_test.cpp",
+ "SurfaceInterceptor_test.cpp",
+ "Transaction_test.cpp",
+ ],
+ data: ["SurfaceFlinger_test.filter"],
+ static_libs: [
+ "libtrace_proto",
+ ],
+ shared_libs: [
+ "libandroid",
+ "libbinder",
+ "libcutils",
+ "libEGL",
+ "libGLESv2",
+ "libgui",
+ "liblog",
+ "libprotobuf-cpp-full",
+ "libui",
+ "libutils",
+ ]
+
+}
+
+subdirs = [
+ "fakehwc",
+ "hwc2",
+ "vsync",
+ "waitforvsync",
+]
diff --git a/services/surfaceflinger/tests/Android.mk b/services/surfaceflinger/tests/Android.mk
deleted file mode 100644
index 43e22a0..0000000
--- a/services/surfaceflinger/tests/Android.mk
+++ /dev/null
@@ -1,44 +0,0 @@
-# Build the unit tests,
-LOCAL_PATH:= $(call my-dir)
-include $(CLEAR_VARS)
-LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/Android.mk
-
-LOCAL_MODULE := SurfaceFlinger_test
-LOCAL_COMPATIBILITY_SUITE := device-tests
-LOCAL_MODULE_TAGS := tests
-
-LOCAL_SRC_FILES := \
- Transaction_test.cpp \
- Stress_test.cpp \
- SurfaceInterceptor_test.cpp
-
-LOCAL_SHARED_LIBRARIES := \
- libEGL \
- libGLESv2 \
- libbinder \
- libcutils \
- libgui \
- libprotobuf-cpp-full \
- libui \
- libutils \
- libandroid \
- liblog
-
-LOCAL_STATIC_LIBRARIES := libtrace_proto
-
-LOCAL_CFLAGS += -Wall -Werror -Wunused -Wunreachable-code
-
-LOCAL_TEST_DATA = SurfaceFlinger_test.filter
-
-# Build the binary to $(TARGET_OUT_DATA_NATIVE_TESTS)/$(LOCAL_MODULE)
-# to integrate with auto-test framework.
-include $(BUILD_NATIVE_TEST)
-
-# Include subdirectory makefiles
-# ============================================================
-
-# If we're building with ONE_SHOT_MAKEFILE (mm, mmm), then what the framework
-# team really wants is to build the stuff defined by this makefile.
-ifeq (,$(ONE_SHOT_MAKEFILE))
-include $(call first-makefiles-under,$(LOCAL_PATH))
-endif
diff --git a/services/surfaceflinger/tests/fakehwc/Android.bp b/services/surfaceflinger/tests/fakehwc/Android.bp
index eeb0f54..8e0ba83 100644
--- a/services/surfaceflinger/tests/fakehwc/Android.bp
+++ b/services/surfaceflinger/tests/fakehwc/Android.bp
@@ -1,5 +1,8 @@
cc_test {
name: "sffakehwc_test",
+ defaults: ["surfaceflinger_defaults"],
+ tags: ["test"],
+ test_suites: ["device-tests"],
srcs: [
"FakeComposerClient.cpp",
"FakeComposerService.cpp",
@@ -7,36 +10,31 @@
"SFFakeHwc_test.cpp"
],
shared_libs: [
- "libcutils",
- "libutils",
- "libbinder",
- "libui",
- "libgui",
- "liblog",
- "libnativewindow",
"android.hardware.graphics.composer@2.1",
"android.hardware.graphics.mapper@2.0",
- "libhwbinder",
+ "libbase",
+ "libbinder",
+ "libcutils",
+ "libfmq",
+ "libgui",
"libhardware",
"libhidlbase",
- "libsync",
- "libfmq",
- "libbase",
"libhidltransport",
- "liblayers_proto"
+ "libhwbinder",
+ "liblayers_proto",
+ "liblog",
+ "libnativewindow",
+ "libsync",
+ "libui",
+ "libutils",
],
static_libs: [
"libhwcomposer-client",
- "libsurfaceflingerincludes",
"libtrace_proto",
"libgmock"
],
header_libs: [
"android.hardware.graphics.composer@2.1-command-buffer",
+ "libsurfaceflinger_headers",
],
- cppflags: [
- "-std=c++1z",
- ],
- tags: ["tests"],
- test_suites: ["device-tests"]
}
\ No newline at end of file
diff --git a/services/surfaceflinger/tests/hwc2/Android.bp b/services/surfaceflinger/tests/hwc2/Android.bp
new file mode 100644
index 0000000..e980522
--- /dev/null
+++ b/services/surfaceflinger/tests/hwc2/Android.bp
@@ -0,0 +1,56 @@
+// Copyright (C) 2018 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+cc_test {
+ name: "test-hwc2",
+ defaults: ["surfaceflinger_defaults"],
+ tags: ["test"],
+ cflags: [
+ "-DEGL_EGLEXT_PROTOTYPES",
+ "-DGL_GLEXT_PROTOTYPES",
+ "-fno-builtin",
+ "-fstack-protector-all",
+ "-g",
+ "-Wextra",
+ ],
+ srcs: [
+ "Hwc2Test.cpp",
+ "Hwc2TestProperties.cpp",
+ "Hwc2TestLayer.cpp",
+ "Hwc2TestLayers.cpp",
+ "Hwc2TestBuffer.cpp",
+ "Hwc2TestClientTarget.cpp",
+ "Hwc2TestVirtualDisplay.cpp",
+ "Hwc2TestPixelComparator.cpp",
+ ],
+ static_libs: [
+ "libadf",
+ "libadfhwc",
+ "libbase",
+ "libmath",
+ ],
+ shared_libs: [
+ "android.hardware.graphics.common@1.0",
+ "libcutils",
+ "libEGL",
+ "libGLESv2",
+ "libgui",
+ "libhardware",
+ "libhwui",
+ "liblog",
+ "libsync",
+ "libui",
+ "libutils",
+ ],
+}
diff --git a/services/surfaceflinger/tests/hwc2/Android.mk b/services/surfaceflinger/tests/hwc2/Android.mk
deleted file mode 100644
index 010ac9c..0000000
--- a/services/surfaceflinger/tests/hwc2/Android.mk
+++ /dev/null
@@ -1,57 +0,0 @@
-#
-# Copyright (C) 2016 The Android Open Source Project
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-
-LOCAL_PATH := $(call my-dir)
-
-include $(CLEAR_VARS)
-
-LOCAL_MODULE := test-hwc2
-LOCAL_MODULE_TAGS := tests
-LOCAL_CFLAGS += \
- -fstack-protector-all \
- -g \
- -Wall -Wextra \
- -Werror \
- -fno-builtin \
- -DEGL_EGLEXT_PROTOTYPES \
- -DGL_GLEXT_PROTOTYPES
-LOCAL_SHARED_LIBRARIES := \
- libcutils \
- libutils \
- libhardware \
- libEGL \
- libGLESv2 \
- libui \
- libgui \
- liblog \
- libsync \
- libhwui \
- android.hardware.graphics.common@1.0
-LOCAL_STATIC_LIBRARIES := \
- libbase \
- libadf \
- libadfhwc \
- libmath
-LOCAL_SRC_FILES := \
- Hwc2Test.cpp \
- Hwc2TestProperties.cpp \
- Hwc2TestLayer.cpp \
- Hwc2TestLayers.cpp \
- Hwc2TestBuffer.cpp \
- Hwc2TestClientTarget.cpp \
- Hwc2TestVirtualDisplay.cpp \
- Hwc2TestPixelComparator.cpp
-
-include $(BUILD_NATIVE_TEST)
diff --git a/services/surfaceflinger/tests/vsync/Android.bp b/services/surfaceflinger/tests/vsync/Android.bp
new file mode 100644
index 0000000..d04efda
--- /dev/null
+++ b/services/surfaceflinger/tests/vsync/Android.bp
@@ -0,0 +1,30 @@
+// Copyright (C) 2018 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+cc_binary {
+ name: "test-vsync-events",
+ defaults: ["surfaceflinger_defaults"],
+ tags: ["test"],
+ srcs: [
+ "vsync.cpp",
+ ],
+ shared_libs: [
+ "libbinder",
+ "libcutils",
+ "libgui",
+ "libui",
+ "libutils",
+ ]
+
+}
diff --git a/services/surfaceflinger/tests/vsync/Android.mk b/services/surfaceflinger/tests/vsync/Android.mk
deleted file mode 100644
index 8e41617..0000000
--- a/services/surfaceflinger/tests/vsync/Android.mk
+++ /dev/null
@@ -1,20 +0,0 @@
-LOCAL_PATH:= $(call my-dir)
-include $(CLEAR_VARS)
-
-LOCAL_SRC_FILES:= \
- vsync.cpp
-
-LOCAL_SHARED_LIBRARIES := \
- libcutils \
- libutils \
- libbinder \
- libui \
- libgui
-
-LOCAL_MODULE:= test-vsync-events
-
-LOCAL_MODULE_TAGS := tests
-
-LOCAL_CFLAGS := -Werror
-
-include $(BUILD_EXECUTABLE)
diff --git a/services/surfaceflinger/tests/waitforvsync/Android.bp b/services/surfaceflinger/tests/waitforvsync/Android.bp
new file mode 100644
index 0000000..cb6d0fd
--- /dev/null
+++ b/services/surfaceflinger/tests/waitforvsync/Android.bp
@@ -0,0 +1,26 @@
+// Copyright (C) 2018 The Android Open Source Project
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+cc_binary {
+ name: "test-waitforvsync",
+ cflags: [
+ "-Werror",
+ ],
+ srcs: [
+ "waitforvsync.cpp",
+ ],
+ shared_libs: [
+ "libcutils",
+ ]
+}
diff --git a/services/surfaceflinger/tests/waitforvsync/Android.mk b/services/surfaceflinger/tests/waitforvsync/Android.mk
deleted file mode 100644
index 932d2be..0000000
--- a/services/surfaceflinger/tests/waitforvsync/Android.mk
+++ /dev/null
@@ -1,16 +0,0 @@
-LOCAL_PATH:= $(call my-dir)
-include $(CLEAR_VARS)
-
-LOCAL_SRC_FILES:= \
- waitforvsync.cpp
-
-LOCAL_SHARED_LIBRARIES := \
- libcutils \
-
-LOCAL_MODULE:= test-waitforvsync
-
-LOCAL_MODULE_TAGS := tests
-
-LOCAL_CFLAGS := -Werror
-
-include $(BUILD_EXECUTABLE)