commit 655d5710fdb42524376649df0ef9953437479cd6
author Steven Moreland <smoreland@google.com> Tue Feb 14 00:19:40 2023 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Feb 14 00:19:40 2023 +0000
tree 158f273e7fa7d64d669aefec01a917586b8c5743
parent 6aae53692e0a81ae263e25927214e79808cfdb38

Revert "libbinder: Flush excess refs after single async transaction"

This reverts commit 6aae53692e0a81ae263e25927214e79808cfdb38.

Reason for revert: b/268238590
Bug: 268238590
Test: binderRpcTestNoKernel --gtest_filter="*OnewayCallQueueingWithFds/unix_domain_socket_bootstrap_raw_clientV4026531840_serverV4026531840_no_kernel*" --gtest_repeat=10000 --gtest_break_on_failure

(this change causes tests to flake, reverting for now)

Change-Id: I2dd4e347228791085f3f2534f948839ee27c16b6

libs/binder/RpcState.cpp

diff --git a/libs/binder/RpcState.cpp b/libs/binder/RpcState.cpp
index 1ea13f9..b27f102 100644
--- a/libs/binder/RpcState.cpp
+++ b/libs/binder/RpcState.cpp
@@ -1036,8 +1036,8 @@
                 return DEAD_OBJECT;
             }
 
-            if (it->second.asyncTodo.size() != 0 &&
-                it->second.asyncTodo.top().asyncNumber == it->second.asyncNumber) {
+            if (it->second.asyncTodo.size() == 0) return OK;
+            if (it->second.asyncTodo.top().asyncNumber == it->second.asyncNumber) {
                 LOG_RPC_DETAIL("Found next async transaction %" PRIu64 " on %" PRIu64,
                                it->second.asyncNumber, addr);