commit 65381d826447502d150f2b92c08376951fe3584c
author Steven Moreland <smoreland@google.com> Sat May 22 01:37:10 2021 +0000
committer Steven Moreland <smoreland@google.com> Sat May 22 01:37:10 2021 +0000
tree 46d89f64e158bf2c9a3d22b394c52158d37136e2
parent 9e8b642768128fcdb84f64591334aff4ba301070

libbinder: harder failure on poll failure

Fail hard, fail fast (until proven otherwise)

Bug: 185167543
Test: binderRpcTest, binder_rpc_fuzzer
Change-Id: I6a5dcbb19d79d42c528a61e95718caa02512a12c

libs/binder/RpcSession.cpp

diff --git a/libs/binder/RpcSession.cpp b/libs/binder/RpcSession.cpp
index 6a539d1..cba560c 100644
--- a/libs/binder/RpcSession.cpp
+++ b/libs/binder/RpcSession.cpp
@@ -132,7 +132,7 @@
         int ret = TEMP_FAILURE_RETRY(poll(pfd, arraysize(pfd), -1));
         if (ret < 0) {
             ALOGE("Could not poll: %s", strerror(errno));
-            continue;
+            return false;
         }
         if (ret == 0) {
             continue;