commit 618c43f778a4b486a2deb273e0883048ad6ac216
author Matt Buckley <mattbuckley@google.com> Fri Aug 12 18:09:48 2022 +0000
committer Matt Buckley <mattbuckley@google.com> Fri Aug 12 18:09:48 2022 +0000
tree da6cb7302c4aea0404cc76b3b6fffbbef1ae8b3c
parent e3a5470621e0a19aecc6708eae0553fda02dd7e3

Revert "Check for adpf cpu hints for SurfaceFlinger during init"

This reverts commit e3a5470621e0a19aecc6708eae0553fda02dd7e3.

Reason for revert: testing if this causes regression

Change-Id: I565852db0359b7780e3e21a46db4fabf542ca32a

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index e06ee38..4f54f17 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -686,22 +686,23 @@
 
         readPersistentProperties();
         mPowerAdvisor->onBootFinished();
-
-        // try to enable power hint session again using mendel flag now that boot is finished,
-        // but only if we didn't already try earlier
-        if (!mPowerAdvisor->usePowerHintSession() && mFlagManager.use_adpf_cpu_hint()) {
-            mPowerAdvisor->enablePowerHint(true);
-            // check again to make sure it's actually supported
-            if (mPowerAdvisor->usePowerHintSession()) {
-                startPowerHintSession();
+        const bool powerHintEnabled = mFlagManager.use_adpf_cpu_hint();
+        mPowerAdvisor->enablePowerHint(powerHintEnabled);
+        const bool powerHintUsed = mPowerAdvisor->usePowerHintSession();
+        ALOGD("Power hint is %s",
+              powerHintUsed ? "supported" : (powerHintEnabled ? "unsupported" : "disabled"));
+        if (powerHintUsed) {
+            std::optional<pid_t> renderEngineTid = getRenderEngine().getRenderEngineTid();
+            std::vector<int32_t> tidList;
+            tidList.emplace_back(gettid());
+            if (renderEngineTid.has_value()) {
+                tidList.emplace_back(*renderEngineTid);
+            }
+            if (!mPowerAdvisor->startPowerHintSession(tidList)) {
+                ALOGW("Cannot start power hint session");
             }
         }
 
-        ALOGD("Power hint session is %s",
-              mPowerAdvisor->usePowerHintSession()
-                      ? "enabled"
-                      : (!mPowerAdvisor->supportsPowerHintSession() ? "unsupported" : "disabled"));
-
         mBootStage = BootStage::FINISHED;
 
         if (property_get_bool("sf.debug.show_refresh_rate_overlay", false)) {
@@ -825,11 +826,6 @@
 
     mPowerAdvisor->init();
 
-    mPowerAdvisor->enablePowerHint(mFlagManager.use_adpf_cpu_hint());
-    if (mPowerAdvisor->usePowerHintSession()) {
-        startPowerHintSession();
-    }
-
     char primeShaderCache[PROPERTY_VALUE_MAX];
     property_get("service.sf.prime_shader_cache", primeShaderCache, "1");
     if (atoi(primeShaderCache)) {
@@ -7222,18 +7218,6 @@
     return true;
 }
 
-void SurfaceFlinger::startPowerHintSession() const {
-    std::optional<pid_t> renderEngineTid = getRenderEngine().getRenderEngineTid();
-    std::vector<int32_t> tidList;
-    tidList.emplace_back(gettid());
-    if (renderEngineTid.has_value()) {
-        tidList.emplace_back(*renderEngineTid);
-    }
-    if (!mPowerAdvisor->startPowerHintSession(tidList)) {
-        ALOGW("Cannot start power hint session");
-    }
-}
-
 // gui::ISurfaceComposer
 
 binder::Status SurfaceComposerAIDL::bootFinished() {