Mark IDisplayService as deprecated.
Nothing uses this in the Android tree that I can find, but for being
cautious and according to Treble rules, deprecating this service.
Funny story, I implemented this service around midnight or so because I
couldn't wait to get that vsync data out of there!
If any device is using this service and needs to launch on Android T,
please reach out. We could deliver another solution or restore this
temporarily. However, in general, using binder calls to do frame timing
is pretty errorprone. You may prefer sync fences or similar.
Fixes: 141930622
Test: boot cf, lshal | grep display
Test: atest vts_treble_vintf_{vendor,framework}_test
Change-Id: Id7fcf18c74aedc8f15af4529552b2138d545224a
diff --git a/services/surfaceflinger/main_surfaceflinger.cpp b/services/surfaceflinger/main_surfaceflinger.cpp
index 673239d..caeff4a 100644
--- a/services/surfaceflinger/main_surfaceflinger.cpp
+++ b/services/surfaceflinger/main_surfaceflinger.cpp
@@ -63,18 +63,17 @@
return OK;
}
-static status_t startDisplayService() {
+static void startDisplayService() {
using android::frameworks::displayservice::V1_0::implementation::DisplayService;
using android::frameworks::displayservice::V1_0::IDisplayService;
sp<IDisplayService> displayservice = new DisplayService();
status_t err = displayservice->registerAsService();
+ // b/141930622
if (err != OK) {
- ALOGE("Could not register IDisplayService service.");
+ ALOGE("Did not register (deprecated) IDisplayService service.");
}
-
- return err;
}
int main(int, char**) {