commit 5e79880085a1bd33c1650b6f5fc450d0d7f84f9e
author Steven Moreland <smoreland@google.com> Mon Sep 24 11:21:57 2018 -0700
committer Steven Moreland <smoreland@google.com> Mon Sep 24 17:34:36 2018 -0700
tree 1a40c03afa3e1576a3ca8c41d83b681acd26dce5
parent 85eaa63b1d122790d364ae02cdc8a8c2f1e73cf3

libbinder_ndk: don't preserve positive statuses

This was a bug introduced during the development of this code when
positive errors were considered service specific errors. This isn't
actually how the API works, but when later patchsets were added, the
code being removed here wasn't removed.

Bug: 111445392
Test: atest android.binder.cts
Change-Id: I83e06fa8f0d76dfba35f9b2d971e5491c103ee70

libs/binder/ndk/status.cpp

diff --git a/libs/binder/ndk/status.cpp b/libs/binder/ndk/status.cpp
index 549e4b3..e0ae469 100644
--- a/libs/binder/ndk/status.cpp
+++ b/libs/binder/ndk/status.cpp
@@ -71,8 +71,6 @@
 }
 
 binder_status_t PruneStatusT(status_t status) {
-    if (status > 0) return status;
-
     switch (status) {
         case ::android::OK:
             return STATUS_OK;