commit 5e74c65a55e2297228e1c8cf7885420d6a946e80
author Chia-I Wu <olv@google.com> Wed May 17 13:43:16 2017 -0700
committer Chia-I Wu <olv@google.com> Wed May 17 14:21:04 2017 -0700
tree 6085b23bdee85e40ddbde5c0e70c9881cba68662
parent 4052245c532fdb5bb665714d7d613c7313dc6a91

surfaceflinger: fix a release fence leak

We leak release fence fds when we believe hwcomposer2 gives us any
invalid layer and return early.

Bug: 38151478
Test: boots
Change-Id: I299721eca8bc7927052170fe87ee51e9b91006aa

services/surfaceflinger/DisplayHardware/HWC2.cpp

diff --git a/services/surfaceflinger/DisplayHardware/HWC2.cpp b/services/surfaceflinger/DisplayHardware/HWC2.cpp
index 8270c39..15b72c4 100644
--- a/services/surfaceflinger/DisplayHardware/HWC2.cpp
+++ b/services/surfaceflinger/DisplayHardware/HWC2.cpp
@@ -917,6 +917,9 @@
         } else {
             ALOGE("getReleaseFences: invalid layer %" PRIu64
                     " found on display %" PRIu64, layerIds[element], mId);
+            for (; element < numElements; ++element) {
+                close(fenceFds[element]);
+            }
             return Error::BadLayer;
         }
     }