commit 5af964cd57a27a8aa49e1969daed9ee21d58d1f9
author Atneya Nair <atneya@google.com> Thu Mar 21 16:36:06 2024 -0700
committer Atneya Nair <atneya@google.com> Fri Mar 22 12:19:50 2024 -0700
tree 5493051dd8a1a57b49b27c7d5756a31bff07860b
parent 97834be3f83400470536a67d8a188a134f8010a3

Migrate BatteryStats audio calls to oneway

The batterystats binder interfaces used by audioserver are currently
synchronous, which causes layering violations leading to threadpool
starvation in system server.

Migrate the calls used by audioserver in particular to oneway. These
calls are already void returning, and are logically async.

Fixes: 330359963
Test: dumpsys batterystats contains audio info
Change-Id: I271eb5e8cf709e0e7b74ed767c5e232ba0e548b7

libs/binder/IBatteryStats.cpp

diff --git a/libs/binder/IBatteryStats.cpp b/libs/binder/IBatteryStats.cpp
index 69b11c0..7b58046 100644
--- a/libs/binder/IBatteryStats.cpp
+++ b/libs/binder/IBatteryStats.cpp
@@ -66,14 +66,14 @@
         Parcel data, reply;
         data.writeInterfaceToken(IBatteryStats::getInterfaceDescriptor());
         data.writeInt32(uid);
-        remote()->transact(NOTE_START_AUDIO_TRANSACTION, data, &reply);
+        remote()->transact(NOTE_START_AUDIO_TRANSACTION, data, &reply, IBinder::FLAG_ONEWAY);
     }
 
     virtual void noteStopAudio(int uid) {
         Parcel data, reply;
         data.writeInterfaceToken(IBatteryStats::getInterfaceDescriptor());
         data.writeInt32(uid);
-        remote()->transact(NOTE_STOP_AUDIO_TRANSACTION, data, &reply);
+        remote()->transact(NOTE_STOP_AUDIO_TRANSACTION, data, &reply, IBinder::FLAG_ONEWAY);
     }
 
     virtual void noteResetVideo() {
@@ -85,7 +85,7 @@
     virtual void noteResetAudio() {
         Parcel data, reply;
         data.writeInterfaceToken(IBatteryStats::getInterfaceDescriptor());
-        remote()->transact(NOTE_RESET_AUDIO_TRANSACTION, data, &reply);
+        remote()->transact(NOTE_RESET_AUDIO_TRANSACTION, data, &reply, IBinder::FLAG_ONEWAY);
     }
 
     virtual void noteFlashlightOn(int uid) {