commit 53d76f1840f952cf8d19e5a79a55d7a8345f2e81
author Chih-Hung Hsieh <chh@google.com> Tue Dec 05 11:36:23 2017 -0800
committer Chih-hung Hsieh <chh@google.com> Tue Dec 05 19:55:34 2017 +0000
tree 5b8dcefd75b4482a0445cfb1a8b1aa7759f208ee
parent bf01f66de5fa5f713ab71d3cfd2e1d5e27e722d7

Fix warnings in frameworks/native/services/surfaceflinger/tests/fakehwc

* Fix typo.
* Ignore returned value of registerAsService?

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I0d9f4372e493547f908f02b07728295bac7d4be3

services/surfaceflinger/tests/fakehwc/FakeComposerClient.cpp

diff --git a/services/surfaceflinger/tests/fakehwc/FakeComposerClient.cpp b/services/surfaceflinger/tests/fakehwc/FakeComposerClient.cpp
index 60916f3..561db8d 100644
--- a/services/surfaceflinger/tests/fakehwc/FakeComposerClient.cpp
+++ b/services/surfaceflinger/tests/fakehwc/FakeComposerClient.cpp
@@ -582,7 +582,7 @@
 }
 
 void FakeComposerClient::onSurfaceFlingerStart() {
-    mSurfaceComposer == nullptr;
+    mSurfaceComposer = nullptr;
     do {
         mSurfaceComposer = new android::SurfaceComposerClient;
         android::status_t initResult = mSurfaceComposer->initCheck();

services/surfaceflinger/tests/fakehwc/SFFakeHwc_test.cpp

diff --git a/services/surfaceflinger/tests/fakehwc/SFFakeHwc_test.cpp b/services/surfaceflinger/tests/fakehwc/SFFakeHwc_test.cpp
index 8902ede..68fefea 100644
--- a/services/surfaceflinger/tests/fakehwc/SFFakeHwc_test.cpp
+++ b/services/surfaceflinger/tests/fakehwc/SFFakeHwc_test.cpp
@@ -163,7 +163,7 @@
     sp<ComposerClient> client = new ComposerClient(*mMockComposer);
     mMockComposer->setClient(client.get());
     mFakeService = new FakeComposerService(client);
-    mFakeService->registerAsService("mock");
+    (void)mFakeService->registerAsService("mock");
 
     android::hardware::ProcessState::self()->startThreadPool();
     android::ProcessState::self()->startThreadPool();
@@ -325,7 +325,7 @@
     sp<ComposerClient> client = new ComposerClient(*sFakeComposer);
     sFakeComposer->setClient(client.get());
     sp<IComposer> fakeService = new FakeComposerService(client);
-    fakeService->registerAsService("mock");
+    (void)fakeService->registerAsService("mock");
 
     android::hardware::ProcessState::self()->startThreadPool();
     android::ProcessState::self()->startThreadPool();