commit 50adab945ac11a190dc6d04f585f7461f8d3185b
author Peiyong Lin <lpy@google.com> Thu Nov 02 23:43:04 2023 +0000
committer Peiyong Lin <lpy@google.com> Thu Nov 02 23:43:04 2023 +0000
tree 3230b82c87c85118c3a8ade29b5c934d112261f2
parent aa21941f474c12e391ce62a8959c34ed8a1ab653

nullptr check on suffix.

The value of suffix could be nullptr, hence we should perform a nullptr
check.

Bug: b/309001559
Test: boot
Change-Id: Ifd0bf521544d378cb438a8d9c3e0ad2ed5a199db

opengl/libs/EGL/Loader.cpp

diff --git a/opengl/libs/EGL/Loader.cpp b/opengl/libs/EGL/Loader.cpp
index 3d31e67..e0ad6d9 100644
--- a/opengl/libs/EGL/Loader.cpp
+++ b/opengl/libs/EGL/Loader.cpp
@@ -494,7 +494,7 @@
     void* dso = nullptr;
 
     // Only use sphal namespace when system ANGLE binaries are not the default drivers.
-    const bool useSphalNamespace = strcmp(suffix, ANGLE_SUFFIX_VALUE) != 0;
+    const bool useSphalNamespace = suffix != nullptr && strcmp(suffix, ANGLE_SUFFIX_VALUE) != 0;
 
     const std::string absolutePath =
             findLibrary(libraryName, useSphalNamespace ? VENDOR_LIB_EGL_DIR : SYSTEM_LIB_PATH,