commit 42a94c6b3592f2aeddcbb39fa23c87136e5f1178
author Sungtak Lee <taklee@google.com> Fri May 24 14:27:14 2019 -0700
committer Sungtak Lee <taklee@google.com> Fri May 24 14:32:31 2019 -0700
tree 8362670c3d7e5d63f7664fe2f11c5693456d67b0
parent d08cd7ea0c556349841641e04d7765398950151e

BufferQueueProducer: fix buffer adjustment during setDequeueTimeout

Adjust buffer during setDequeueTimeout() according to the expected
future value of mDequeueBufferCannotBlock.

Bug: 133208327
Change-Id: Ibc6b1dd6c3870c6c80e76279f1f104200a3d0241

libs/gui/BufferQueueProducer.cpp

diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp
index 96d7568..c20c2f3 100644
--- a/libs/gui/BufferQueueProducer.cpp
+++ b/libs/gui/BufferQueueProducer.cpp
@@ -1497,7 +1497,9 @@
     BQ_LOGV("setDequeueTimeout: %" PRId64, timeout);
 
     std::lock_guard<std::mutex> lock(mCore->mMutex);
-    int delta = mCore->getMaxBufferCountLocked(mCore->mAsyncMode, false,
+    bool dequeueBufferCannotBlock =
+            timeout >= 0 ? false : mCore->mDequeueBufferCannotBlock;
+    int delta = mCore->getMaxBufferCountLocked(mCore->mAsyncMode, dequeueBufferCannotBlock,
             mCore->mMaxBufferCount) - mCore->getMaxBufferCountLocked();
     if (!mCore->adjustAvailableSlotsLocked(delta)) {
         BQ_LOGE("setDequeueTimeout: BufferQueue failed to adjust the number of "
@@ -1506,11 +1508,9 @@
     }
 
     mDequeueTimeout = timeout;
-    if (timeout >= 0) {
-        mCore->mDequeueBufferCannotBlock = false;
-        if (timeout != 0) {
-            mCore->mQueueBufferCanDrop = false;
-        }
+    mCore->mDequeueBufferCannotBlock = dequeueBufferCannotBlock;
+    if (timeout > 0) {
+        mCore->mQueueBufferCanDrop = false;
     }
 
     VALIDATE_CONSISTENCY();