commit 42a6b622f3b71b27d0153ddab9aac9f829a78604
author Shuangxi Xiang <xiangshuangxi@xiaomi.corp-partner.google.com> Fri Jan 10 03:57:14 2025 -0800
committer Shuangxi Xiang <xiangshuangxi@xiaomi.corp-partner.google.com> Fri Jan 10 04:00:25 2025 -0800
tree 93bd828f0e39f0b473b3afa28ac930925ca3548c
parent 33a6e89aa8ebde305ea3bc408d3b5b96756cacd6

Remove redundant local parameters in Client

The Android version upgrade modified the declaration of createLayer and mirrorLayer functions in SurfaceFlinger, removed multiple parameters of objects such as IBinder, and also modified the mirrorDisplay function in Client, causing their local variables sp<IBinder> handle to be redundant.

Signed-off-by:
Shuangxi Xiang <xiangshuangxi@xiaomi.corp-partner.google.com>

Change-Id: Ifa8db1993fa46209a9d935c9ff588d2d0dc4c5f8

services/surfaceflinger/Client.cpp

diff --git a/services/surfaceflinger/Client.cpp b/services/surfaceflinger/Client.cpp
index abeb2a9..77bf145 100644
--- a/services/surfaceflinger/Client.cpp
+++ b/services/surfaceflinger/Client.cpp
@@ -53,7 +53,6 @@
                                      const sp<IBinder>& parent, const gui::LayerMetadata& metadata,
                                      gui::CreateSurfaceResult* outResult) {
     // We rely on createLayer to check permissions.
-    sp<IBinder> handle;
     LayerCreationArgs args(mFlinger.get(), sp<Client>::fromExisting(this), name.c_str(),
                            static_cast<uint32_t>(flags), std::move(metadata));
     args.parentHandle = parent;
@@ -101,7 +100,6 @@
 
 binder::Status Client::mirrorSurface(const sp<IBinder>& mirrorFromHandle,
                                      gui::CreateSurfaceResult* outResult) {
-    sp<IBinder> handle;
     LayerCreationArgs args(mFlinger.get(), sp<Client>::fromExisting(this), "MirrorRoot",
                            0 /* flags */, gui::LayerMetadata());
     status_t status = mFlinger->mirrorLayer(args, mirrorFromHandle, *outResult);
@@ -109,7 +107,6 @@
 }
 
 binder::Status Client::mirrorDisplay(int64_t displayId, gui::CreateSurfaceResult* outResult) {
-    sp<IBinder> handle;
     LayerCreationArgs args(mFlinger.get(), sp<Client>::fromExisting(this),
                            "MirrorRoot-" + std::to_string(displayId), 0 /* flags */,
                            gui::LayerMetadata());