commit 4292810fbe008693390696ae0b9e91e9ffded231
author joenchen <joenchen@google.com> Tue Sep 06 18:03:57 2022 +0000
committer joenchen <joenchen@google.com> Wed Sep 14 17:43:52 2022 +0000
tree 2f2ee9c6003ea8b55af1450405f7f6ce016be531
parent fad66b2c0b0dba8e6df0e023b5f199dbf0598968

Set mBrightness when needsComposite is zero

When needsComposite is zero in persistBrightness(), the mBrightness
needs to be updated to avoid unexpected skipping.

Bug: 244268674
Test: adb shell cmd device_state state 0 or 1 repeatly
Change-Id: Iccf925c1407e4be489da2dba521b93eee1b1c4b5

services/surfaceflinger/DisplayDevice.cpp

diff --git a/services/surfaceflinger/DisplayDevice.cpp b/services/surfaceflinger/DisplayDevice.cpp
index 8680900..269a1fa 100644
--- a/services/surfaceflinger/DisplayDevice.cpp
+++ b/services/surfaceflinger/DisplayDevice.cpp
@@ -325,8 +325,10 @@
 }
 
 void DisplayDevice::persistBrightness(bool needsComposite) {
-    if (needsComposite && mStagedBrightness && mBrightness != *mStagedBrightness) {
-        getCompositionDisplay()->setNextBrightness(*mStagedBrightness);
+    if (mStagedBrightness && mBrightness != *mStagedBrightness) {
+        if (needsComposite) {
+            getCompositionDisplay()->setNextBrightness(*mStagedBrightness);
+        }
         mBrightness = *mStagedBrightness;
     }
     mStagedBrightness = std::nullopt;