commit 40b05d490b3fddfe0d9c3f7caf63a1a60a7cc7b4
author Jiyong Park <jiyong@google.com> Mon Nov 25 11:06:16 2019 +0900
committer Jiyong Park <jiyong@google.com> Wed Dec 18 05:32:42 2019 +0000
tree 418573dc12dc35b0414dcaa41fcee76e6fe8a4a6
parent 5d4883d82c3983ce4b2d820b1bb32a320c4a3442

unique_fd is passed by value in AIDL interfaces

FileDescriptor type in AIDL was translated into const unique_fd& in C++.
Now, it is unique_fd, i.e. passed by value, to make it easier to keep it
beyond the scope of the call.

Bug: 144943748
Test: m

Exempt-From-Owner-Approval: cherry-pick from internal

Merged-In: Id0fead2717b1f6a3b9a1867efa8b588b59d3fbd2
(cherry picked from commit 3b25ae153fb5aaa1d2f70600b45604e3665f0da2)
Change-Id: Id0fead2717b1f6a3b9a1867efa8b588b59d3fbd2

cmds/dumpstate/DumpstateService.cpp

diff --git a/cmds/dumpstate/DumpstateService.cpp b/cmds/dumpstate/DumpstateService.cpp
index f98df99..10d3d17 100644
--- a/cmds/dumpstate/DumpstateService.cpp
+++ b/cmds/dumpstate/DumpstateService.cpp
@@ -115,8 +115,8 @@
 
 binder::Status DumpstateService::startBugreport(int32_t calling_uid,
                                                 const std::string& calling_package,
-                                                const android::base::unique_fd& bugreport_fd,
-                                                const android::base::unique_fd& screenshot_fd,
+                                                android::base::unique_fd bugreport_fd,
+                                                android::base::unique_fd screenshot_fd,
                                                 int bugreport_mode,
                                                 const sp<IDumpstateListener>& listener) {
     MYLOGI("startBugreport() with mode: %d\n", bugreport_mode);