commit 406a285ab039e4bd83fc98fc7c3fb4a9107d8dd2
author George Burgess IV <gbiv@google.com> Tue Aug 29 17:57:25 2017 -0700
committer George Burgess IV <gbiv@google.com> Tue Aug 29 18:03:59 2017 -0700
tree adcf46317d9254a4abac3cdfaa6cae80f326d396
parent 5b843179ff2a5e09e35756ec6145220e9f08acf5

surfaceflinger: fix static analyzer complaints

Due to https://bugs.llvm.org/show_bug.cgi?id=34365, the static analyzer
complains about use of copied `sp`s. In this case, the copy is entirely
unnecessary, since we're just going to destroy the copied-from sp
anyway.

Speed things up a bit + appease the analyzer by moving instead.

Bug: 27101951
Test: mma. Static analyzer no longer complains.
Change-Id: Idf45abcc5c9b3694ef710e330e88a7c2fd766929

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 29e7bd6..bcd7afe 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -2144,7 +2144,7 @@
                     sp<const DisplayDevice> hw(mDisplays[dpy]);
                     if (hw->getLayerStack() == currentlayerStack) {
                         if (disp == NULL) {
-                            disp = hw;
+                            disp = std::move(hw);
                         } else {
                             disp = NULL;
                             break;