commit 3652ba0fac04d5646a2fe39c74de22269b2a8d7c
author Steven Moreland <smoreland@google.com> Fri Jul 21 00:37:18 2023 +0000
committer Steven Moreland <smoreland@google.com> Fri Jul 21 00:37:20 2023 +0000
tree 5036f6a7603943751ece7894e1fb83cf26ed9df6
parent 1411c396f0c11d042916e531e10978c60af1a4b6

binderAllocationLimits: check remote binder null

Possible null de-ref hit one time?

This is not actually expected to fix this bug, but if it reproduces
again, it should give us slightly more information.

Change-Id: Ie3de2b50088179d1c7fcb8d492dfc092a2e45b91
Fixes: 291870594
Test: N/A

libs/binder/tests/binderAllocationLimits.cpp

diff --git a/libs/binder/tests/binderAllocationLimits.cpp b/libs/binder/tests/binderAllocationLimits.cpp
index bc40864..6712c9c 100644
--- a/libs/binder/tests/binderAllocationLimits.cpp
+++ b/libs/binder/tests/binderAllocationLimits.cpp
@@ -216,16 +216,16 @@
     auto server = RpcServer::make();
     server->setRootObject(sp<BBinder>::make());
 
-    CHECK_EQ(OK, server->setupUnixDomainServer(addr.c_str()));
+    ASSERT_EQ(OK, server->setupUnixDomainServer(addr.c_str()));
 
     std::thread([server]() { server->join(); }).detach();
 
-    status_t status;
     auto session = RpcSession::make();
-    status = session->setupUnixDomainClient(addr.c_str());
-    CHECK_EQ(status, OK) << "Could not connect: " << addr << ": " << statusToString(status).c_str();
+    status_t status = session->setupUnixDomainClient(addr.c_str());
+    ASSERT_EQ(status, OK) << "Could not connect: " << addr << ": " << statusToString(status).c_str();
 
     auto remoteBinder = session->getRootObject();
+    ASSERT_NE(remoteBinder, nullptr);
 
     size_t mallocs = 0, totalBytes = 0;
     {
@@ -233,7 +233,7 @@
             mallocs++;
             totalBytes += bytes;
         });
-        CHECK_EQ(OK, remoteBinder->pingBinder());
+        ASSERT_EQ(OK, remoteBinder->pingBinder());
     }
     EXPECT_EQ(mallocs, 1);
     EXPECT_EQ(totalBytes, 40);