SF: wait instead of presenting early
If SurfaceFlinger duration is configured to a larger value
than the vsync period, there might be a chance that SF would
present the frame too early, if its actual duration is much shorter
than anticipating. To prevent this, we wait until the vsync occurs
before calling to hwc::present.
Bug: 185949581
Test: Configure large SF duration and observe systrace
Change-Id: Ic0c112a2808036d0f2e14a345c401fa56c2d29ab
diff --git a/services/surfaceflinger/CompositionEngine/src/Output.cpp b/services/surfaceflinger/CompositionEngine/src/Output.cpp
index 3468b20..faa4b74 100644
--- a/services/surfaceflinger/CompositionEngine/src/Output.cpp
+++ b/services/surfaceflinger/CompositionEngine/src/Output.cpp
@@ -711,6 +711,8 @@
return;
}
+ editState().earliestPresentTime = refreshArgs.earliestPresentTime;
+
sp<GraphicBuffer> previousOverride = nullptr;
for (auto* layer : getOutputLayersOrderedByZ()) {
bool skipLayer = false;