[SurfaceFlinger] Replace android_dataspace with Dataspace.
This patch replaces all android_dataspace in SurfaceFlinger with Dataspace
V1.1. 3 commands in sequence are used to do the conversion:
find ./ -type f -exec sed -i -e 's/android_dataspace_t/Dataspace/g' {} \;
find ./ -type f -exec sed -i -e 's/android_dataspace/Dataspace/g' {} \;
find ./ -type f -exec sed -i -e 's/HAL_DATASPACE_/Dataspace::/g' {} \;
With some minor tweak because most of the APIs in frameworks/native are still
accepting android_dataspace/android_dataspace_t.
Next step is to convert the rest of android_dataspace usage to Dataspace in
frameworks/native as well as frameworks/base.
BUG: 77156734
Test: Build and flash
Change-Id: I2304c7014cb49a1c9f67c4563603fb55e8dbd679
diff --git a/services/surfaceflinger/tests/hwc2/Android.bp b/services/surfaceflinger/tests/hwc2/Android.bp
index e980522..6c0e4ab 100644
--- a/services/surfaceflinger/tests/hwc2/Android.bp
+++ b/services/surfaceflinger/tests/hwc2/Android.bp
@@ -42,6 +42,7 @@
],
shared_libs: [
"android.hardware.graphics.common@1.0",
+ "android.hardware.graphics.common@1.1",
"libcutils",
"libEGL",
"libGLESv2",
diff --git a/services/surfaceflinger/tests/hwc2/Hwc2Test.cpp b/services/surfaceflinger/tests/hwc2/Hwc2Test.cpp
index b3f1b69..13774b4 100644
--- a/services/surfaceflinger/tests/hwc2/Hwc2Test.cpp
+++ b/services/surfaceflinger/tests/hwc2/Hwc2Test.cpp
@@ -36,6 +36,7 @@
#include "Hwc2TestVirtualDisplay.h"
using android::ui::ColorMode;
+using android::ui::Dataspace;
void hwc2TestHotplugCallback(hwc2_callback_data_t callbackData,
hwc2_display_t display, int32_t connected);
@@ -442,14 +443,14 @@
}
void setLayerDataspace(hwc2_display_t display, hwc2_layer_t layer,
- android_dataspace_t dataspace, hwc2_error_t* outErr = nullptr)
+ Dataspace dataspace, hwc2_error_t* outErr = nullptr)
{
auto pfn = reinterpret_cast<HWC2_PFN_SET_LAYER_DATASPACE>(
getFunction(HWC2_FUNCTION_SET_LAYER_DATASPACE));
ASSERT_TRUE(pfn) << "failed to get function";
auto err = static_cast<hwc2_error_t>(pfn(mHwc2Device, display,
- layer, dataspace));
+ layer, static_cast<int>(dataspace)));
if (outErr) {
*outErr = err;
} else {
@@ -790,14 +791,14 @@
void getClientTargetSupport(hwc2_display_t display, int32_t width,
int32_t height, android_pixel_format_t format,
- android_dataspace_t dataspace, hwc2_error_t* outErr = nullptr)
+ Dataspace dataspace, hwc2_error_t* outErr = nullptr)
{
auto pfn = reinterpret_cast<HWC2_PFN_GET_CLIENT_TARGET_SUPPORT>(
getFunction(HWC2_FUNCTION_GET_CLIENT_TARGET_SUPPORT));
ASSERT_TRUE(pfn) << "failed to get function";
auto err = static_cast<hwc2_error_t>(pfn(mHwc2Device, display, width,
- height, format, dataspace));
+ height, format, static_cast<int>(dataspace)));
if (outErr) {
*outErr = err;
} else {
@@ -807,7 +808,7 @@
}
void setClientTarget(hwc2_display_t display, buffer_handle_t handle,
- int32_t acquireFence, android_dataspace_t dataspace,
+ int32_t acquireFence, Dataspace dataspace,
hwc_region_t damage, hwc2_error_t* outErr = nullptr)
{
auto pfn = reinterpret_cast<HWC2_PFN_SET_CLIENT_TARGET>(
@@ -815,7 +816,7 @@
ASSERT_TRUE(pfn) << "failed to get function";
auto err = static_cast<hwc2_error_t>(pfn(mHwc2Device, display, handle,
- acquireFence, dataspace, damage));
+ acquireFence, static_cast<int>(dataspace), damage));
if (outErr) {
*outErr = err;
} else {
@@ -1691,7 +1692,7 @@
const std::set<hwc2_layer_t>& clearLayers, bool flipClientTarget,
const Area& displayArea)
{
- android_dataspace_t dataspace = HAL_DATASPACE_UNKNOWN;
+ Dataspace dataspace = Dataspace::UNKNOWN;
hwc_region_t damage = { };
buffer_handle_t handle;
int32_t acquireFence;
@@ -3716,7 +3717,7 @@
* layer. */
TEST_F(Hwc2Test, SET_CLIENT_TARGET_basic)
{
- const android_dataspace_t dataspace = HAL_DATASPACE_UNKNOWN;
+ const Dataspace dataspace = Dataspace::UNKNOWN;
const hwc_region_t damage = { };
const size_t layerCnt = 1;
@@ -3795,7 +3796,7 @@
std::set<hwc2_layer_t> clientLayers;
std::set<hwc2_layer_t> flipClientTargetLayers;
bool flipClientTarget = true;
- const android_dataspace_t dataspace = HAL_DATASPACE_UNKNOWN;
+ const Dataspace dataspace = Dataspace::UNKNOWN;
const hwc_region_t damage = { };
buffer_handle_t handle;
int32_t acquireFence;
diff --git a/services/surfaceflinger/tests/hwc2/Hwc2TestClientTarget.cpp b/services/surfaceflinger/tests/hwc2/Hwc2TestClientTarget.cpp
index 6925492..14c60a7 100644
--- a/services/surfaceflinger/tests/hwc2/Hwc2TestClientTarget.cpp
+++ b/services/surfaceflinger/tests/hwc2/Hwc2TestClientTarget.cpp
@@ -91,7 +91,7 @@
return mBufferArea.get();
}
-android_dataspace_t Hwc2TestClientTargetSupport::getDataspace() const
+android::ui::Dataspace Hwc2TestClientTargetSupport::getDataspace() const
{
return mDataspace.get();
}
diff --git a/services/surfaceflinger/tests/hwc2/Hwc2TestClientTarget.h b/services/surfaceflinger/tests/hwc2/Hwc2TestClientTarget.h
index 3b47978..6f4090f 100644
--- a/services/surfaceflinger/tests/hwc2/Hwc2TestClientTarget.h
+++ b/services/surfaceflinger/tests/hwc2/Hwc2TestClientTarget.h
@@ -53,7 +53,7 @@
bool advance();
Area getBufferArea() const;
- android_dataspace_t getDataspace() const;
+ android::ui::Dataspace getDataspace() const;
const hwc_region_t getSurfaceDamage() const;
private:
diff --git a/services/surfaceflinger/tests/hwc2/Hwc2TestLayer.cpp b/services/surfaceflinger/tests/hwc2/Hwc2TestLayer.cpp
index 937fce2..c1c9cc8 100644
--- a/services/surfaceflinger/tests/hwc2/Hwc2TestLayer.cpp
+++ b/services/surfaceflinger/tests/hwc2/Hwc2TestLayer.cpp
@@ -146,7 +146,7 @@
return mDisplayFrame.get();
}
-android_dataspace_t Hwc2TestLayer::getDataspace() const
+android::ui::Dataspace Hwc2TestLayer::getDataspace() const
{
return mDataspace.get();
}
diff --git a/services/surfaceflinger/tests/hwc2/Hwc2TestLayer.h b/services/surfaceflinger/tests/hwc2/Hwc2TestLayer.h
index 0e7dd22..29ae521 100644
--- a/services/surfaceflinger/tests/hwc2/Hwc2TestLayer.h
+++ b/services/surfaceflinger/tests/hwc2/Hwc2TestLayer.h
@@ -54,7 +54,7 @@
hwc_color_t getColor() const;
hwc2_composition_t getComposition() const;
hwc_rect_t getCursorPosition() const;
- android_dataspace_t getDataspace() const;
+ android::ui::Dataspace getDataspace() const;
hwc_rect_t getDisplayFrame() const;
float getPlaneAlpha() const;
hwc_frect_t getSourceCrop() const;
diff --git a/services/surfaceflinger/tests/hwc2/Hwc2TestLayers.cpp b/services/surfaceflinger/tests/hwc2/Hwc2TestLayers.cpp
index 495ef79..90127a1 100644
--- a/services/surfaceflinger/tests/hwc2/Hwc2TestLayers.cpp
+++ b/services/surfaceflinger/tests/hwc2/Hwc2TestLayers.cpp
@@ -169,7 +169,7 @@
return mTestLayers.at(layer).getCursorPosition();
}
-android_dataspace_t Hwc2TestLayers::getDataspace(hwc2_layer_t layer) const
+android::ui::Dataspace Hwc2TestLayers::getDataspace(hwc2_layer_t layer) const
{
if (mTestLayers.count(layer) == 0) {
[]() { GTEST_FAIL(); }();
diff --git a/services/surfaceflinger/tests/hwc2/Hwc2TestLayers.h b/services/surfaceflinger/tests/hwc2/Hwc2TestLayers.h
index d95a91f..909dd48 100644
--- a/services/surfaceflinger/tests/hwc2/Hwc2TestLayers.h
+++ b/services/surfaceflinger/tests/hwc2/Hwc2TestLayers.h
@@ -63,7 +63,7 @@
hwc_color_t getColor(hwc2_layer_t layer) const;
hwc2_composition_t getComposition(hwc2_layer_t layer) const;
hwc_rect_t getCursorPosition(hwc2_layer_t layer) const;
- android_dataspace_t getDataspace(hwc2_layer_t layer) const;
+ android::ui::Dataspace getDataspace(hwc2_layer_t layer) const;
hwc_rect_t getDisplayFrame(hwc2_layer_t layer) const;
android_pixel_format_t getFormat(hwc2_layer_t layer) const;
float getPlaneAlpha(hwc2_layer_t layer) const;
diff --git a/services/surfaceflinger/tests/hwc2/Hwc2TestProperties.cpp b/services/surfaceflinger/tests/hwc2/Hwc2TestProperties.cpp
index 5b3bbeb..c5b92d0 100644
--- a/services/surfaceflinger/tests/hwc2/Hwc2TestProperties.cpp
+++ b/services/surfaceflinger/tests/hwc2/Hwc2TestProperties.cpp
@@ -262,62 +262,62 @@
std::string Hwc2TestDataspace::dump() const
{
std::stringstream dmp;
- dmp << "\tdataspace: " << get() << "\n";
+ dmp << "\tdataspace: " << static_cast<int32_t>(get()) << "\n";
return dmp.str();
}
-const std::vector<android_dataspace_t> Hwc2TestDataspace::defaultDataspaces = {
- HAL_DATASPACE_UNKNOWN,
+const std::vector<android::ui::Dataspace> Hwc2TestDataspace::defaultDataspaces = {
+ android::ui::Dataspace::UNKNOWN,
};
-const std::vector<android_dataspace_t> Hwc2TestDataspace::basicDataspaces = {
- HAL_DATASPACE_UNKNOWN,
- HAL_DATASPACE_V0_SRGB,
+const std::vector<android::ui::Dataspace> Hwc2TestDataspace::basicDataspaces = {
+ android::ui::Dataspace::UNKNOWN,
+ android::ui::Dataspace::V0_SRGB,
};
-const std::vector<android_dataspace_t> Hwc2TestDataspace::completeDataspaces = {
- HAL_DATASPACE_UNKNOWN,
- HAL_DATASPACE_ARBITRARY,
- HAL_DATASPACE_STANDARD_SHIFT,
- HAL_DATASPACE_STANDARD_MASK,
- HAL_DATASPACE_STANDARD_UNSPECIFIED,
- HAL_DATASPACE_STANDARD_BT709,
- HAL_DATASPACE_STANDARD_BT601_625,
- HAL_DATASPACE_STANDARD_BT601_625_UNADJUSTED,
- HAL_DATASPACE_STANDARD_BT601_525,
- HAL_DATASPACE_STANDARD_BT601_525_UNADJUSTED,
- HAL_DATASPACE_STANDARD_BT2020,
- HAL_DATASPACE_STANDARD_BT2020_CONSTANT_LUMINANCE,
- HAL_DATASPACE_STANDARD_BT470M,
- HAL_DATASPACE_STANDARD_FILM,
- HAL_DATASPACE_TRANSFER_SHIFT,
- HAL_DATASPACE_TRANSFER_MASK,
- HAL_DATASPACE_TRANSFER_UNSPECIFIED,
- HAL_DATASPACE_TRANSFER_LINEAR,
- HAL_DATASPACE_TRANSFER_SRGB,
- HAL_DATASPACE_TRANSFER_SMPTE_170M,
- HAL_DATASPACE_TRANSFER_GAMMA2_2,
- HAL_DATASPACE_TRANSFER_GAMMA2_8,
- HAL_DATASPACE_TRANSFER_ST2084,
- HAL_DATASPACE_TRANSFER_HLG,
- HAL_DATASPACE_RANGE_SHIFT,
- HAL_DATASPACE_RANGE_MASK,
- HAL_DATASPACE_RANGE_UNSPECIFIED,
- HAL_DATASPACE_RANGE_FULL,
- HAL_DATASPACE_RANGE_LIMITED,
- HAL_DATASPACE_SRGB_LINEAR,
- HAL_DATASPACE_V0_SRGB_LINEAR,
- HAL_DATASPACE_SRGB,
- HAL_DATASPACE_V0_SRGB,
- HAL_DATASPACE_JFIF,
- HAL_DATASPACE_V0_JFIF,
- HAL_DATASPACE_BT601_625,
- HAL_DATASPACE_V0_BT601_625,
- HAL_DATASPACE_BT601_525,
- HAL_DATASPACE_V0_BT601_525,
- HAL_DATASPACE_BT709,
- HAL_DATASPACE_V0_BT709,
- HAL_DATASPACE_DEPTH,
+const std::vector<android::ui::Dataspace> Hwc2TestDataspace::completeDataspaces = {
+ android::ui::Dataspace::UNKNOWN,
+ android::ui::Dataspace::ARBITRARY,
+ android::ui::Dataspace::STANDARD_SHIFT,
+ android::ui::Dataspace::STANDARD_MASK,
+ android::ui::Dataspace::STANDARD_UNSPECIFIED,
+ android::ui::Dataspace::STANDARD_BT709,
+ android::ui::Dataspace::STANDARD_BT601_625,
+ android::ui::Dataspace::STANDARD_BT601_625_UNADJUSTED,
+ android::ui::Dataspace::STANDARD_BT601_525,
+ android::ui::Dataspace::STANDARD_BT601_525_UNADJUSTED,
+ android::ui::Dataspace::STANDARD_BT2020,
+ android::ui::Dataspace::STANDARD_BT2020_CONSTANT_LUMINANCE,
+ android::ui::Dataspace::STANDARD_BT470M,
+ android::ui::Dataspace::STANDARD_FILM,
+ android::ui::Dataspace::TRANSFER_SHIFT,
+ android::ui::Dataspace::TRANSFER_MASK,
+ android::ui::Dataspace::TRANSFER_UNSPECIFIED,
+ android::ui::Dataspace::TRANSFER_LINEAR,
+ android::ui::Dataspace::TRANSFER_SRGB,
+ android::ui::Dataspace::TRANSFER_SMPTE_170M,
+ android::ui::Dataspace::TRANSFER_GAMMA2_2,
+ android::ui::Dataspace::TRANSFER_GAMMA2_8,
+ android::ui::Dataspace::TRANSFER_ST2084,
+ android::ui::Dataspace::TRANSFER_HLG,
+ android::ui::Dataspace::RANGE_SHIFT,
+ android::ui::Dataspace::RANGE_MASK,
+ android::ui::Dataspace::RANGE_UNSPECIFIED,
+ android::ui::Dataspace::RANGE_FULL,
+ android::ui::Dataspace::RANGE_LIMITED,
+ android::ui::Dataspace::SRGB_LINEAR,
+ android::ui::Dataspace::V0_SRGB_LINEAR,
+ android::ui::Dataspace::SRGB,
+ android::ui::Dataspace::V0_SRGB,
+ android::ui::Dataspace::JFIF,
+ android::ui::Dataspace::V0_JFIF,
+ android::ui::Dataspace::BT601_625,
+ android::ui::Dataspace::V0_BT601_625,
+ android::ui::Dataspace::BT601_525,
+ android::ui::Dataspace::V0_BT601_525,
+ android::ui::Dataspace::BT709,
+ android::ui::Dataspace::V0_BT709,
+ android::ui::Dataspace::DEPTH,
};
diff --git a/services/surfaceflinger/tests/hwc2/Hwc2TestProperties.h b/services/surfaceflinger/tests/hwc2/Hwc2TestProperties.h
index cb811e0..d7082f3 100644
--- a/services/surfaceflinger/tests/hwc2/Hwc2TestProperties.h
+++ b/services/surfaceflinger/tests/hwc2/Hwc2TestProperties.h
@@ -20,6 +20,7 @@
#include <array>
#include <vector>
+#include <ui/GraphicTypes.h>
#include <ui/Region.h>
#define HWC2_INCLUDE_STRINGIFICATION
@@ -229,16 +230,16 @@
};
-class Hwc2TestDataspace : public Hwc2TestProperty<android_dataspace_t> {
+class Hwc2TestDataspace : public Hwc2TestProperty<android::ui::Dataspace> {
public:
Hwc2TestDataspace(Hwc2TestCoverage coverage);
std::string dump() const override;
protected:
- static const std::vector<android_dataspace_t> defaultDataspaces;
- static const std::vector<android_dataspace_t> basicDataspaces;
- static const std::vector<android_dataspace_t> completeDataspaces;
+ static const std::vector<android::ui::Dataspace> defaultDataspaces;
+ static const std::vector<android::ui::Dataspace> basicDataspaces;
+ static const std::vector<android::ui::Dataspace> completeDataspaces;
static const std::array<bool, 6> mCompositionSupport;
};
diff --git a/services/surfaceflinger/tests/unittests/MockComposer.h b/services/surfaceflinger/tests/unittests/MockComposer.h
index acd9b30..00e565b 100644
--- a/services/surfaceflinger/tests/unittests/MockComposer.h
+++ b/services/surfaceflinger/tests/unittests/MockComposer.h
@@ -29,10 +29,10 @@
using android::hardware::graphics::common::V1_0::ColorMode;
using android::hardware::graphics::common::V1_0::ColorTransform;
-using android::hardware::graphics::common::V1_0::Dataspace;
using android::hardware::graphics::common::V1_0::Hdr;
-using android::hardware::graphics::common::V1_0::PixelFormat;
using android::hardware::graphics::common::V1_0::Transform;
+using android::hardware::graphics::common::V1_1::Dataspace;
+using android::hardware::graphics::common::V1_1::PixelFormat;
using android::hardware::graphics::composer::V2_1::Config;
using android::hardware::graphics::composer::V2_1::Display;
diff --git a/services/surfaceflinger/tests/unittests/MockRenderEngine.h b/services/surfaceflinger/tests/unittests/MockRenderEngine.h
index 6d3e17f..9bb2a3c 100644
--- a/services/surfaceflinger/tests/unittests/MockRenderEngine.h
+++ b/services/surfaceflinger/tests/unittests/MockRenderEngine.h
@@ -64,8 +64,8 @@
MOCK_METHOD0(disableTexturing, void());
MOCK_METHOD0(disableBlending, void());
MOCK_METHOD1(setSourceY410BT2020, void(bool));
- MOCK_METHOD1(setSourceDataSpace, void(android_dataspace));
- MOCK_METHOD1(setOutputDataSpace, void(android_dataspace));
+ MOCK_METHOD1(setSourceDataSpace, void(ui::Dataspace));
+ MOCK_METHOD1(setOutputDataSpace, void(ui::Dataspace));
MOCK_METHOD2(bindNativeBufferAsFrameBuffer,
void(ANativeWindowBuffer*, RE::BindNativeBufferAsFramebuffer*));
MOCK_METHOD1(unbindNativeBufferAsFrameBuffer, void(RE::BindNativeBufferAsFramebuffer*));