commit 2ec5688a56fcf7147e086962f544f01128291325
author Yifan Hong <elsk@google.com> Fri Sep 10 15:57:10 2021 -0700
committer Yifan Hong <elsk@google.com> Mon Sep 13 16:22:18 2021 -0700
tree 3f75bd0e5c7e774f746404be34a553589bc98221
parent 180c2daee47abcfd0eeaf327239470543e1cc669

binder: X509 are serialized to vector<uint8_t>

Change it from a string to a vector<uint8_t>. For DER
format, it is not a print-able string.

Test: pass
Bug: 198833574
Change-Id: I6b4d0ebc2d7429e927f7ca5abccc3f6aedfe1e6a

libs/binder/RpcTransportTls.cpp

diff --git a/libs/binder/RpcTransportTls.cpp b/libs/binder/RpcTransportTls.cpp
index 180b76e..c42ea9a 100644
--- a/libs/binder/RpcTransportTls.cpp
+++ b/libs/binder/RpcTransportTls.cpp
@@ -450,7 +450,7 @@
             std::shared_ptr<RpcCertificateVerifier> verifier);
     std::unique_ptr<RpcTransport> newTransport(android::base::unique_fd fd,
                                                FdTrigger* fdTrigger) const override;
-    std::string getCertificate(CertificateFormat) const override;
+    std::vector<uint8_t> getCertificate(CertificateFormat) const override;
 
 protected:
     static ssl_verify_result_t sslCustomVerify(SSL* ssl, uint8_t* outAlert);
@@ -459,7 +459,7 @@
     std::shared_ptr<RpcCertificateVerifier> mCertVerifier;
 };
 
-std::string RpcTransportCtxTls::getCertificate(CertificateFormat) const {
+std::vector<uint8_t> RpcTransportCtxTls::getCertificate(CertificateFormat) const {
     // TODO(b/195166979): return certificate here
     return {};
 }