surfaceflinger: fix fillRegionWithColor
This was regressed by commit 1be50b50ab, where vertices were assumed
to be in Vulkan coordinate convention.
Bug: 114439058
Test: hide cutout
Change-Id: I0eafa61cb83c8a682d74d869cd3736b63f393d31
diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index 55ef909..b1740b8 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -1688,9 +1688,8 @@
doComposeSurfaces(display);
// and draw the dirty region
- const int32_t height = display->getHeight();
auto& engine(getRenderEngine());
- engine.fillRegionWithColor(dirtyRegion, height, 1, 0, 1, 1);
+ engine.fillRegionWithColor(dirtyRegion, 1, 0, 1, 1);
display->swapBuffers(getHwComposer());
}
@@ -3194,7 +3193,7 @@
// screen is already cleared here
if (!region.isEmpty()) {
// can happen with SurfaceView
- drawWormhole(display, region);
+ drawWormhole(region);
}
}
@@ -3262,11 +3261,9 @@
return true;
}
-void SurfaceFlinger::drawWormhole(const sp<const DisplayDevice>& display,
- const Region& region) const {
- const int32_t height = display->getHeight();
+void SurfaceFlinger::drawWormhole(const Region& region) const {
auto& engine(getRenderEngine());
- engine.fillRegionWithColor(region, height, 0, 0, 0, 0);
+ engine.fillRegionWithColor(region, 0, 0, 0, 0);
}
status_t SurfaceFlinger::addClientLayer(const sp<Client>& client,