commit 249fd7f0135e9927b76070c9721307ef6d741269
author Vishnu Nair <vishnun@google.com> Thu Jun 22 19:30:24 2023 -0700
committer Vishnu Nair <vishnun@google.com> Thu Jun 22 19:36:59 2023 -0700
tree 19469993b3446efa9fee6d8e3c99ed2d765f511e
parent 6db5aaf680a8c9297d3187586827a4d0f3a94c8e

[sf] fix transaction tracing path typo

Bug: 282110579, 238781169
Fixes: 277265947
Test: presubmit

Change-Id: I2066f606337005eb049ad721ff80f34c9989b8c1

services/surfaceflinger/SurfaceFlinger.cpp

diff --git a/services/surfaceflinger/SurfaceFlinger.cpp b/services/surfaceflinger/SurfaceFlinger.cpp
index c6fdcfe..f84b09c 100644
--- a/services/surfaceflinger/SurfaceFlinger.cpp
+++ b/services/surfaceflinger/SurfaceFlinger.cpp
@@ -97,6 +97,7 @@
 #include <utils/Timers.h>
 #include <utils/misc.h>
 
+#include <unistd.h>
 #include <algorithm>
 #include <cerrno>
 #include <cinttypes>
@@ -916,11 +917,9 @@
             auto writeFn = [&]() {
                 const std::string filename =
                         TransactionTracing::DIR_NAME + prefix + TransactionTracing::FILE_NAME;
-                if (overwrite) {
-                    std::ifstream file(filename);
-                    if (file.is_open()) {
-                        return;
-                    }
+                if (overwrite && access(filename.c_str(), F_OK) == 0) {
+                    ALOGD("TransactionTraceWriter: file=%s already exists", filename.c_str());
+                    return;
                 }
                 mTransactionTracing->flush();
                 mTransactionTracing->writeToFile(filename);