Use const reference in setGpuStats() API
Rather than make a copy of these strings when the function is
called, we pass them by const reference.
Test: TreeHugger
Change-Id: Ief53fea1f6df191181e00eab978cf53b5a2ab91d
diff --git a/services/gpuservice/GpuService.cpp b/services/gpuservice/GpuService.cpp
index 9906dea..68c185c 100644
--- a/services/gpuservice/GpuService.cpp
+++ b/services/gpuservice/GpuService.cpp
@@ -37,9 +37,9 @@
GpuService::GpuService() = default;
-void GpuService::setGpuStats(const std::string driverPackageName,
- const std::string driverVersionName, const uint64_t driverVersionCode,
- const std::string appPackageName) {
+void GpuService::setGpuStats(const std::string& driverPackageName,
+ const std::string& driverVersionName, const uint64_t driverVersionCode,
+ const std::string& appPackageName) {
ATRACE_CALL();
std::lock_guard<std::mutex> lock(mStateLock);
diff --git a/services/gpuservice/GpuService.h b/services/gpuservice/GpuService.h
index edfd364..5304fa1 100644
--- a/services/gpuservice/GpuService.h
+++ b/services/gpuservice/GpuService.h
@@ -37,8 +37,8 @@
private:
// IGpuService interface
- void setGpuStats(const std::string driverPackageName, const std::string driverVersionName,
- const uint64_t driverVersionCode, const std::string appPackageName);
+ void setGpuStats(const std::string& driverPackageName, const std::string& driverVersionName,
+ const uint64_t driverVersionCode, const std::string& appPackageName);
// GpuStats access must be protected by mStateLock
std::mutex mStateLock;