commit 207def90db004d0cbe0277c5926b712e0d4d9f02
author Lloyd Pique <lpique@google.com> Thu Feb 28 16:09:52 2019 -0800
committer Lloyd Pique <lpique@google.com> Fri Mar 15 09:24:33 2019 -0700
tree 3da3218ce11aab1e1154793801a432c9da53eb3a
parent a83776ca89ba291b05ad97c63cc4f8c595625379

SF: Dump CompositionEngine layers and cleanup output

No code was calling compositionengine::Layer::dump. This adds a call,
and cleans up a few odd details about the output so it looks
reasonable.

Test: dumpsys SurfaceFlinger
Bug: 121291683

Change-Id: Iad524ddcd1fe99c0a1670a8ebb045ecbffd5b2eb

services/surfaceflinger/CompositionEngine/src/DumpHelpers.cpp

diff --git a/services/surfaceflinger/CompositionEngine/src/DumpHelpers.cpp b/services/surfaceflinger/CompositionEngine/src/DumpHelpers.cpp
index c497013..9598430 100644
--- a/services/surfaceflinger/CompositionEngine/src/DumpHelpers.cpp
+++ b/services/surfaceflinger/CompositionEngine/src/DumpHelpers.cpp
@@ -24,7 +24,7 @@
 using android::base::StringAppendF;
 
 void dumpVal(std::string& out, const char* name, bool value) {
-    StringAppendF(&out, "%s=%c ", name, value ? 'T' : 'F');
+    StringAppendF(&out, "%s=%s ", name, value ? "true" : "false");
 }
 
 void dumpVal(std::string& out, const char* name, const void* value) {
@@ -56,7 +56,7 @@
 }
 
 void dumpVal(std::string& out, const char* name, const char* valueName, int value) {
-    StringAppendF(&out, "%s=%s (%d)", name, valueName, value);
+    StringAppendF(&out, "%s=%s (%d) ", name, valueName, value);
 }
 
 void dumpVal(std::string& out, const char* name, const std::string& valueName, int value) {