commit 1e5d4e56120971b3b57bdbcadc4ce6b4cdf99621
author Treehugger Robot <treehugger-gerrit@google.com> Mon Sep 13 22:15:25 2021 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> Mon Sep 13 22:15:25 2021 +0000
tree db7ad091769b2c841d9c96d355fb02b13fd7c974
parent fa64e8b448f83db62cd1298978b286f16fef08fa
parent 7e75c7da3452ba3ddf509536969c6a1431d53317

Merge "BufferQueueProducer: Log verbose log to warning instead of error." am: e9b2010fb1 am: bf8edbe041 am: 2824e91bef am: 7e75c7da34

Original change: https://android-review.googlesource.com/c/platform/frameworks/native/+/1822354

Change-Id: I03b29e0eda9dc602e229910c6204f23a48e1bdb5

libs/gui/BufferQueueProducer.cpp

diff --git a/libs/gui/BufferQueueProducer.cpp b/libs/gui/BufferQueueProducer.cpp
index df308d8..5fe5e71 100644
--- a/libs/gui/BufferQueueProducer.cpp
+++ b/libs/gui/BufferQueueProducer.cpp
@@ -645,7 +645,10 @@
                     slot, BufferQueueDefs::NUM_BUFFER_SLOTS);
             return BAD_VALUE;
         } else if (!mSlots[slot].mBufferState.isDequeued()) {
-            BQ_LOGE("detachBuffer: slot %d is not owned by the producer "
+            // TODO(http://b/140581935): This message is BQ_LOGW because it
+            // often logs when no actionable errors are present. Return to
+            // using BQ_LOGE after ensuring this only logs during errors.
+            BQ_LOGW("detachBuffer: slot %d is not owned by the producer "
                     "(state = %s)", slot, mSlots[slot].mBufferState.string());
             return BAD_VALUE;
         } else if (!mSlots[slot].mRequestBufferCalled) {