commit 1c16df541e8b1a67a042fbb20b6e2c76446e9748
author Fan Xu <fanxu@google.com> Mon Nov 19 16:27:27 2018 -0800
committer Fan Xu <fanxu@google.com> Tue Dec 04 10:25:26 2018 -0800
tree ce3e9724f9b43679a73d922b60cc2129412d07b3
parent 023162b7e6872c42552de35380d348ab3e785fac

Fix freeId() failed in ~BufferNode

And rename UniqueIdGenerator to BufferHubIdGenerator.

Created a static getter and Use scoped static initialization for
UniqueIdGenerator.

Test: run BufferHubBuffer_test, then "adb logcat | grep bufferhub -i" to
verify that there are no error messages.
Fix: 118844348
Change-Id: Ia75ae4dac13cc709f39161c803401bcbb90c70e2

services/bufferhub/BufferNode.cpp

diff --git a/services/bufferhub/BufferNode.cpp b/services/bufferhub/BufferNode.cpp
index 715d0a1..ec84849 100644
--- a/services/bufferhub/BufferNode.cpp
+++ b/services/bufferhub/BufferNode.cpp
@@ -66,8 +66,8 @@
     }
 
     // Free the id, if valid
-    if (id() != UniqueIdGenerator::kInvalidId) {
-        if (nodeIdGenerator.freeId(id())) {
+    if (id() != BufferHubIdGenerator::kInvalidId) {
+        if (BufferHubIdGenerator::getInstance().freeId(id())) {
             ALOGI("%s: id #%u is freed.", __FUNCTION__, id());
         } else {
             ALOGE("%s: Cannot free nonexistent id #%u", __FUNCTION__, id());