commit 1474f8864faafebc92ff79959bb5c698bd29b704
author Dan Albert <danalbert@google.com> Mon Sep 08 18:59:09 2014 -0700
committer Dan Albert <danalbert@google.com> Tue Sep 16 17:52:06 2014 -0700
tree 7e60cb941b744698bb8bf40e81f50ff14c46e987
parent 86aeb9ef154d7aa63c58cbe5be62e5b61d6ae5fa

Don't check if this == NULL.

Entering a method with this == NULL is undefined behavior. Clang whines
about this.

Change-Id: Ibde628395ca10dfef0d2f59e81280576f104b83c

libs/binder/IInterface.cpp

diff --git a/libs/binder/IInterface.cpp b/libs/binder/IInterface.cpp
index 29acf5d..99a9ffe 100644
--- a/libs/binder/IInterface.cpp
+++ b/libs/binder/IInterface.cpp
@@ -29,12 +29,12 @@
 
 sp<IBinder> IInterface::asBinder()
 {
-    return this ? onAsBinder() : NULL;
+    return onAsBinder();
 }
 
 sp<const IBinder> IInterface::asBinder() const
 {
-    return this ? const_cast<IInterface*>(this)->onAsBinder() : NULL;
+    return const_cast<IInterface*>(this)->onAsBinder();
 }
 
 // ---------------------------------------------------------------------------